fergalmoran/picard
1
0
Fork 0
mirror of https://github.com/fergalmoran/picard.git synced 2026-02-25 00:53:59 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix removal of ~length from sets, incorrect single-element tuple syntax

Browse Source 
The `discard` argument is expected to be a sequence, but the syntax `discard=('elem')` is equivalent to `discard='elem'`.
A trailing comma is needed in this case: `discard=('elem',)` so discard is actually a tuple with a single element.
This commit is contained in:
Laurent Monin
2018-01-17 15:15:38 +01:00
parent ee08a43102
commit 01c5437a27
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
picard/ui/metadatabox.py
View File

@@ -268,7 +268,7 @@ class MetadataBox(QtWidgets.QTableWidget):
def contextMenuEvent(self, event):
menu = QtWidgets.QMenu(self)
if self.objects:
tags = self.selected_tags(discard=('~length'))
tags = self.selected_tags(discard=('~length',))
if len(tags) == 1:
selected_tag = tags[0]
edit_tag_action = QtWidgets.QAction(_("Edit..."), self.parent)
@@ -345,7 +345,7 @@ class MetadataBox(QtWidgets.QTableWidget):
EditTagDialog(self.parent, tag).exec_()
def edit_selected_tag(self):
tags = self.selected_tags(discard=('~length'))
tags = self.selected_tags(discard=('~length',))
if len(tags) == 1:
self.edit_tag(tags[0])
@@ -368,7 +368,7 @@ class MetadataBox(QtWidgets.QTableWidget):
self.set_tag_values(tag, [""])
def remove_selected_tags(self):
for tag in self.selected_tags(discard=('~length')):
for tag in self.selected_tags(discard=('~length',)):
if self.tag_is_removable(tag):
self.remove_tag(tag)