Merge pull request #733 from samj1912/remove-imports

Remove unused imports

picard/__init__.py

@@ -49,7 +49,6 @@ def version_to_string(version, short=False):
             n = int(p)
         except ValueError:
             n = p
-            pass
         _version.append(n)
     version = tuple(_version)
     if short and version[3] == 'final':

picard/config_upgrade.py

@@ -191,7 +191,6 @@ def upgrade_to_v1_4_0_dev_4():
 def upgrade_to_v1_4_0_dev_5():
     """Using Picard.ini configuration file on all platforms"""
     # this is done in Config.__init__()
-    pass
 
 
 def upgrade_to_v1_4_0_dev_6():

picard/coverart/providers/amazon.py

@@ -22,7 +22,6 @@
 # along with this program; if not, write to the Free Software
 # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
 
-import traceback
 
 from picard import log
 from picard.util import parse_amazon_url

picard/coverart/providers/caa.py

@@ -22,7 +22,6 @@
 # along with this program; if not, write to the Free Software
 # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
 
-import traceback
 from PyQt5 import QtCore, QtWidgets
 from PyQt5.QtNetwork import QNetworkReply
 from picard import config, log
@@ -33,7 +32,6 @@ from picard.coverart.utils import CAA_TYPES, translate_caa_type
 from picard.ui.ui_provider_options_caa import Ui_CaaOptions
 from picard.ui.util import StandardButton
 from picard.util import webbrowser2, load_json
-from picard.ui.options import OptionsPage, OptionsCheckError, register_options_page
 
 
 _CAA_THUMBNAIL_SIZE_MAP = {

picard/coverart/providers/caa_release_group.py

@@ -17,9 +17,7 @@
 # along with this program; if not, write to the Free Software
 # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
 
-import traceback
 
-from picard.coverart.providers import CoverArtProvider
 from picard.coverart.providers.caa import CoverArtProviderCaa
 from picard.coverart.image import CaaCoverArtImage, CaaThumbnailCoverArtImage
 

picard/coverart/providers/local.py

@@ -19,7 +19,6 @@
 
 import os
 import re
-import traceback
 from picard import config
 from picard.coverart.providers import CoverArtProvider, ProviderOptions
 from picard.coverart.image import CoverArtImageFromFile

picard/coverart/providers/whitelist.py

@@ -22,7 +22,6 @@
 # along with this program; if not, write to the Free Software
 # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
 
-import traceback
 
 from picard import log
 from picard.coverart.providers import CoverArtProvider

picard/formats/wav.py

@@ -43,4 +43,3 @@ class WAVFile(File):
 
     def _save(self, filename, metadata):
         log.debug("Saving file %r", filename)
-        pass

picard/ui/infodialog.py

@@ -168,7 +168,6 @@ class InfoDialog(PicardDialog):
                         data = image.thumbnail.data
                     except CoverArtImageIOError as e:
                         log.warning(e)
-                        pass
                 else:
                     data = image.data
             except CoverArtImageIOError:

picard/ui/itemviews.py

@@ -19,7 +19,6 @@
 
 import os
 import re
-import sys
 from functools import partial
 from PyQt5 import QtCore, QtGui, QtWidgets
 from picard import config, log

picard/ui/ui_infodialog.py

@@ -16,7 +16,6 @@ class Ui_InfoDialog(object):
         self.info_tab = QtWidgets.QWidget()
         self.info_tab.setObjectName("info_tab")
         self.vboxlayout = QtWidgets.QVBoxLayout(self.info_tab)
-        self.vboxlayout.setContentsMargins(0, 0, 0, 0)
         self.vboxlayout.setObjectName("vboxlayout")
         self.info_scroll = QtWidgets.QScrollArea(self.info_tab)
         self.info_scroll.setWidgetResizable(True)
@@ -41,7 +40,6 @@ class Ui_InfoDialog(object):
         self.artwork_tab = QtWidgets.QWidget()
         self.artwork_tab.setObjectName("artwork_tab")
         self.vboxlayout1 = QtWidgets.QVBoxLayout(self.artwork_tab)
-        self.vboxlayout1.setContentsMargins(0, 0, 0, 0)
         self.vboxlayout1.setObjectName("vboxlayout1")
         self.tabWidget.addTab(self.artwork_tab, "")
         self.verticalLayout.addWidget(self.tabWidget)