fergalmoran/picard
1
0
Fork 0
mirror of https://github.com/fergalmoran/picard.git synced 2026-02-19 06:03:59 +00:00
Code Issues Packages Projects Releases Wiki Activity
10,603 Commits 1 Branch 0 Tags
2a986cd175bc6605ccd4eb578047c1918974b995
Commit Graph

10603 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Laurent Monin
2a986cd175 Revert "Update picard/ui/ui_options_maintenance.py" 
This reverts commit 686df504cb.
 2024-04-24 17:39:50 +02:00
Laurent Monin
686df504cb Update picard/ui/ui_options_maintenance.py 
Co-authored-by: Bob Swift <bswift@rsds.ca>
 2024-04-24 17:26:00 +02:00
Laurent Monin
9edd5845ad Update picard/ui/options/maintenance.py 
Co-authored-by: Bob Swift <bswift@rsds.ca>
 2024-04-24 17:25:38 +02:00
Laurent Monin
2aa55618b9 Reduce code redundancy, introduce _safe_autobackup_dir() 2024-04-24 15:49:07 +02:00
Laurent Monin
cbdb48d5d5 Rework success/error/confirmation/select dialogs 
Move UI code to _dialog_*() and reformat texts
 2024-04-24 15:49:07 +02:00
Laurent Monin
7ab181ead2 _backup_error() -> _dialog_backup_error() 2024-04-24 15:49:07 +02:00
Laurent Monin
71e5b023ea Let the user select the auto backup directory in Maintenance Options 2024-04-24 15:49:07 +02:00
Laurent Monin
87b7388835 Don't import os.path as path, that's a fairly common variable name 2024-04-24 15:49:07 +02:00
Laurent Monin
bea318ed57 Merge pull request #2431 from zas/fix_macos 
Python 3.9 isn't available anymore with macos-latest, stick to macos-12
 2024-04-24 10:51:36 +02:00
Laurent Monin
4da5c29027 Python 3.9 isn't available anymore with macos-latest, stick to macos-12 2024-04-24 10:34:17 +02:00
Lctrs
ae0b2b29ee metainfo: fix recommended display length definition 
According to https://www.freedesktop.org/software/appstream/docs/chap-Metadata.html#tag-relations-display_length, display length's value must be an integer value corresponding to logical pixels.

I took `768`px as value because it corresponds to the recommended referenced size for laptops and tablets, which should match imho the previous incorrect `medium` value.

This fix flathub's build as they don't allow releasing builds with invalid appdata (even if it's just a warning). Running `appstreamcli validate` do raise this warning: `W: org.musicbrainz.Picard:318: relation-display-length-value-invalid medium` currently.
 2024-04-24 07:06:10 +02:00
Laurent Monin
eec6513ce8 Only register sys.excepthook if the app actually started 
Without this patch, when running tests the crash message box may be displayed.
With those changes, it will be displayed only if the app was actually started.
 2024-04-24 07:03:34 +02:00
Laurent Monin
d7bb9dc0a2 Drop remaining bits of QtCore.QObject.config and QtCore.QObject.log 2024-04-24 07:01:45 +02:00
Vac31
da4ff8c03b Translated using Weblate (Lithuanian) 
Currently translated at 66.5% (791 of 1188 strings)

Co-authored-by: Vac31 <gateway_31@protonmail.com>
Translate-URL: https://translations.metabrainz.org/projects/picard/3/app/lt/
Translation: Picard/App
 2024-04-23 16:42:32 +00:00
Laurent Monin
5cea1f24db Merge pull request #2424 from zas/byebye_qtcore_qobject_tagger 
PICARD-2871: Get rid of `QtCore.QObject.tagger`
 2024-04-23 09:20:23 +02:00
Philipp Wolfer
3b6b90d6a6 Fix unit tests after removal of QObject.tagger 2024-04-22 17:59:57 +02:00
Laurent Monin
05023ab096 setup_config(): make app optional 
If app isn't passed just defaults to current application
Use explicit keyword arguments
 2024-04-22 17:59:57 +02:00
Laurent Monin
cca828c7b7 Use QtCore.QCoreApplication.instance() 
Instead of `QtCore.QObject.tagger`
 2024-04-22 17:53:47 +02:00
Philipp Wolfer
b7b43ca09d Fixed calls to QFileDialog options 
The code is invalid in PyQt6 and also just was supposed to set the
standard options being set anyway.
 2024-04-22 16:17:56 +02:00
Hosted Weblate
d592358348 Update translation files 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Co-authored-by: Hosted Weblate <hosted@weblate.org>
Translate-URL: https://translations.metabrainz.org/projects/picard/3/app/
Translation: Picard/App
 2024-04-22 10:04:01 +00:00
Philipp Wolfer
b851b136be Update picard.pot 2024-04-22 12:03:44 +02:00
Laurent Monin
e7149d41b1 Merge pull request #2421 from zas/get_rid_of_custom_builtins 
PICARD-2870: Get rid of monkeypatched gettext-related builtins
 2024-04-22 11:59:13 +02:00
Laurent Monin
a0ebf70768 Get rid of i18n._get_translation(), use dict entries directly 2024-04-22 11:26:12 +02:00
Laurent Monin
134cfce668 Regenerate ui_* files 2024-04-22 10:48:44 +02:00
Laurent Monin
5d0c68c9da Rework setup.py compile_ui to handle Qt6 vs ours translation systems 2024-04-22 10:48:44 +02:00
Laurent Monin
10d2992253 import _ -> import gettext as _ 2024-04-22 10:42:49 +02:00
Laurent Monin
fc87e6cba2 i18n: _gettext() -> gettext(), gettext -> module_gettext 
It will let do:
from picard.i18n import gettext
or
from picard.i18n import gettext as _
 2024-04-21 23:46:19 +02:00
Laurent Monin
2aebd616b4 Remove builtins declarations for checkers 2024-04-21 23:24:03 +02:00
Laurent Monin
2cf9323210 Remove obsolete comment 2024-04-21 23:24:03 +02:00
Laurent Monin
fada4f0a40 Import gettext-related methods, instead of monkeypatching builtins 2024-04-21 23:24:03 +02:00
Philipp Wolfer
ebfd011a99 Merge pull request #2418 from phw/register-excepthook 
PICARD-2869: Register a global exception handler
 2024-04-21 20:05:16 +02:00
Philipp Wolfer
ffdb549b57 PICARD-2192: Fix macOS app bundle creation 2024-04-21 20:04:40 +02:00
Philipp Wolfer
0858846563 PICARD-2192: Do not strip architectures from macOS binary 
This is required to preserve arm64 binary code.
 2024-04-21 19:10:00 +02:00
Philipp Wolfer
b4a6d492f7 PICARD-2869: Use newer syntax for getting exception info on Python >= 3.10 2024-04-21 18:36:47 +02:00
Philipp Wolfer
7251071435 Fixed debug opt test cases not being run 
Fixed the naming of the test class so it actually gets collected and run
 2024-04-21 17:48:44 +02:00
Laurent Monin
226ebef845 Merge pull request #2415 from zas/fix_standalone_track_genres 
PICARD-2866: Fix standalone track genres
 2024-04-20 18:03:21 +02:00
Laurent Monin
fbeb45b45b Merge pull request #2417 from zas/search_cleanup 
Search cleanup
 2024-04-20 18:03:06 +02:00
Philipp Wolfer
d796b1ec29 PICARD-2869: Register a global exception handler 
Register a handler on sys.excepthook and have it call the global
crash_handler(). This allows to show the exception dialog in otherwise
unhandled exceptions.
 2024-04-20 17:44:04 +02:00
Laurent Monin
b2fec6989e self.file_ -> file 2024-04-20 17:41:20 +02:00
Laurent Monin
9e9ba13105 track['musicbrainz_releasegroupid'] -> releasegroup_id 2024-04-20 17:41:20 +02:00
Laurent Monin
f9e361a8ad track['musicbrainz_albumid'] -> album_id 2024-04-20 17:41:20 +02:00
Laurent Monin
de22449c99 track['musicbrainz_recordingid'] -> recording_id 2024-04-20 17:41:20 +02:00
Laurent Monin
d00cdace14 Move part of the code from load_selection() to new _load_selection_nat() 2024-04-20 17:41:20 +02:00
Laurent Monin
3713de5a25 Move part of the code from load_selection() to new _load_selection_non_nat() 2024-04-20 17:41:20 +02:00
Laurent Monin
e89c4df8f7 Revamp code a bit and add few comments to make things clearer 2024-04-20 17:41:20 +02:00
Laurent Monin
d16e5dd448 PICARD-2868: don't try to move a non-existing file after search 2024-04-20 17:38:40 +02:00
Laurent Monin
11445ff000 NonAlbumTrack: fix genres on refresh, clear genres before loading 2024-04-20 13:28:04 +02:00
Laurent Monin
8f2406ed9a Make DataObj.genres a property (internally using _genres) 2024-04-20 13:27:24 +02:00
Laurent Monin
05ddd5fc46 Merge pull request #2414 from zas/alternative_versions_tooltip 
PICARD-2863: Add a tooltip with additional disambiguation to release versions menu
 2024-04-19 17:58:07 +02:00
Laurent Monin
93b71014a6 Add a tooltip with additional disambiguation to release versions menu 2024-04-19 16:03:54 +02:00