Sambhav Kothari
46ffed563b
Fix indentation and remove unnecessary variables
2016-12-27 21:40:10 +05:30
Laurent Monin
8cf5d6b4c4
Merge pull request #500 from samj1912/gnomesupport
...
PICARD-857: Remove deprecated checks and add…
2016-12-27 14:35:24 +01:00
Sambhav Kothari
0a5fddc3f5
Fix dconf key and remove redundant code
2016-12-27 18:52:56 +05:30
Sambhav Kothari
d6bd7769ec
Refactor icontheme.py and fix formatting
2016-12-27 18:34:09 +05:30
Laurent Monin
ac3f793f36
Merge pull request #501 from samj1912/removable-tags
...
PICARD-546,287: Add support for tag removal
2016-12-27 13:57:54 +01:00
Sambhav Kothari
bbf67738bc
PEP8 Fixes
2016-12-27 18:19:11 +05:30
Sambhav Kothari
ae7726567a
Refactor vorbis deletion
2016-12-27 16:51:59 +05:30
Sambhav Kothari
aefcef9098
Refactor mp4 deletion
2016-12-27 16:51:46 +05:30
Sambhav Kothari
31440c41ca
Refactor id3 deletion
2016-12-27 16:51:35 +05:30
Sambhav Kothari
ba4ca48ba5
Refactor asf deletion
2016-12-27 16:51:09 +05:30
Sambhav Kothari
81ad27a84f
Refactor apev2 deletion
2016-12-27 16:50:53 +05:30
Laurent Monin
0e5f2106ef
Merge pull request #511 from samj1912/dockerize
...
Dockerize the Travis build
2016-12-27 11:43:17 +01:00
Sambhav Kothari
cd732ddd20
Dockerize the Travis build
...
Note: Related PR-510 to fix tests for docker
2016-12-27 15:44:52 +05:30
Laurent Monin
27e97c07c6
Merge pull request #510 from samj1912/testfilename
...
Fetch max filename length from system for unix
2016-12-27 10:22:51 +01:00
Sambhav Kothari
08e101755a
Fetch max filename length from system for unix
...
Instead of hardcoding the value to 255, fetch the max filename length
from system limits.
Related: Docker limits max filename size to 242
2016-12-27 01:47:38 +05:30
Sambhav Kothari
a10bfdaf98
Add tests to check for complex tag deletion
2016-12-25 20:56:26 +05:30
Sambhav Kothari
910b7fbd55
Add support for more complex deletions
2016-12-25 20:56:01 +05:30
Sambhav Kothari
fb64a83ae3
PEP8 Fixes
2016-12-24 01:45:24 +05:30
Michael Wiencek
2a7d4869b7
Merge pull request #505 from samj1912/uirecreate
...
Recreate the .ui files corresponding to the ui/ui_* files
2016-12-23 12:04:59 -06:00
Sambhav Kothari
0509465e8d
Remove unused function
2016-12-23 22:38:04 +05:30
Sambhav Kothari
630c46b940
Recreate infodialog and shift ArtworkTable class to appropriate file
2016-12-23 22:37:32 +05:30
Sambhav Kothari
23f14d545b
Update interface options .ui file to add additional checkbox
2016-12-23 01:23:46 +05:30
Sambhav Kothari
1ed867556b
Update caa options .ui file to add additional checkbox
2016-12-23 01:12:29 +05:30
Michael Wiencek
277f445a40
Merge pull request #497 from samj1912/picard855
...
PICARD-855: Adds errorhandler for missing meta-data
2016-12-22 11:01:26 -06:00
Michael Wiencek
4a9fce2d1b
Merge pull request #496 from samj1912/picard851
...
PICARD-851: Correctly update parent items on save
2016-12-22 10:58:12 -06:00
Michael Wiencek
999ced13d6
Merge pull request #504 from samj1912/patch-1
...
Correct the indentation
2016-12-22 10:53:48 -06:00
samj1912
a4d8e03bc0
Correct the indentation
2016-12-22 21:18:31 +05:30
Sambhav Kothari
f2b32655c9
Make error handling more specific
2016-12-22 20:35:44 +05:30
Sambhav Kothari
2dab1d4dc7
Remove unnecessary whitespace
2016-12-22 20:29:59 +05:30
Sambhav Kothari
770ab3fe1c
Make parent variable to avoid multiple function calls
2016-12-21 02:37:24 +05:30
Sambhav Kothari
8fb33658e8
Fix formatting errors
2016-12-20 18:44:59 +05:30
Sambhav Kothari
7f25a28dbc
Add removable tags
2016-12-20 18:30:10 +05:30
Sambhav Kothari
eddee11fa3
PICARD-546,287: Add support for tag removal
2016-12-16 21:46:33 +05:30
Sambhav Kothari
ef6bea2fdf
PICARD-857: Remove deprecated checks and add…
...
…support for GNOME 3 and Unity
Gnome 3 recommends using dconf to get and set values, as a result
gconftool-2 does not return a value in gnome3. Also GNOME_SESSION_ID
as a variable has been deprecated, so the detection of Gnome as a DE
has been changed accordingly.
2016-12-16 00:37:24 +05:30
Sambhav Kothari
5da9838a20
PICARD-857: Add themeing support for GNOME-3 and remove deprecated checks
...
Gnome 3 recommends using gsettings to get and set values, as a result
gconftool-2 does not return a value in gnome3. Also GNOME_SESSION_ID
as a variable has been deprecated, so the detection of Gnome as a DE
has been changed accordingly.
2016-12-16 00:36:15 +05:30
Wieland Hoffmann
572743fb6d
Merge pull request #499 from samj1912/nosetest
...
Add support for nosetests
2016-12-14 21:08:10 +01:00
Sambhav Kothari
43311e4a5e
Add support for nosetests
2016-12-15 01:35:30 +05:30
samj1912
d2f078da1d
Remove quotes from theme name
2016-12-15 01:16:25 +05:30
Sambhav Kothari
0189b6cd8a
PICARD-857: Add themeing support for GNOME-3 and remove deprecated checks
...
Gnome 3 recommends using gsettings to get and set values, as a result
gconftool-2 does not return a value in gnome3. Also GNOME_SESSION_ID
as a variable has been deprecated, so the detection of Gnome as a DE
has been changed accordingly.
2016-12-14 21:10:11 +05:30
Sambhav Kothari
97c83c5777
PICARD-855: Adds errorhandler for missing meta-data
...
When a track with a non valid total-tracks has multiple release matches
on Picard, picard tries to apply a linear combination of weights to
detect the best match. In the process it tried to typecast totaltracks
into and int.
This causes a ValueError when totaltracks is not castable into an int.
2016-12-13 05:39:05 +05:30
Sambhav Kothari
40d934250b
PICARD-851: Correctly update parent items on save
...
When multiple files were linked to the same track and the changes to
the items were saved, the parent album icon didn't update to reflect
the change.
This was because of a buggy item.save() function which led to an update
call to the update() method of files. The files on update did not recu-
rsively call their parent items to be updated too.
2016-12-13 01:22:28 +05:30
Wieland Hoffmann
dcc91099a2
Don't recommend nose while the test are broken when using it
...
[ci skip]
2016-12-12 18:35:51 +01:00
Wieland Hoffmann
0a65151b71
He, she, it, das 's' muss mit
...
[ci skip]
2016-12-12 18:35:46 +01:00
Wieland Hoffmann
7dfc47a7f6
PICARD-853: Don't iterate over empty tracklists
...
Mediums with only data tracks (like disc 2 of
https://musicbrainz.org/release/5855689f-db31-476c-9207-1b966ed44e07 ) don't have
track elements in their track-list element, so make sure we don't try to access
them.
2016-12-06 19:58:48 +01:00
Wieland Hoffmann
1e52735275
Merge branch 'setupcfg'
2016-11-20 16:06:10 +01:00
Wieland Hoffmann
db9072bcaa
Add setup.cfg to ignore flake8 errors
...
This ignores E501 (line too long), some indentation related errors and
configures gettext functions as known builtins, which makes the error
list for most files very short.
Messages in the generated UI files are ignored as well.
This reduces the number of warnings from ~2300 to ~200.
2016-11-20 12:50:04 +01:00
Wieland Hoffmann
8e0118c6de
PICARD-852: Use HTTPS for requests to the plugins API on picard.mbo
2016-11-05 14:32:08 +01:00
Wieland Hoffmann
46dbab97b9
Fix a missing traceback import
2016-10-24 17:30:04 +02:00
Wieland Hoffmann
03a9166799
Fix missing *Dialog class imports
2016-10-24 17:28:20 +02:00
Wieland Hoffmann
b4fa0f4a3f
Fix lookups by work id
2016-10-24 17:21:27 +02:00
