Commit Graph

9036 Commits

Author SHA1 Message Date
skelly37
5f27781635 os-specific filename tests with decorators 2022-06-15 21:13:40 +02:00
skelly37
d029a9d824 better logger, tuple split into lines 2022-06-15 08:54:43 +02:00
skelly37
83bbdb3e18 fallback path generates warn, tests descriped where appliable, path is tested 2022-06-14 19:34:27 +02:00
skelly37
6782ddf0c5 suggestions included, minor refactor 2022-06-14 18:56:58 +02:00
skelly37
c1d708cf5b TypeError fixed 2022-06-14 18:37:13 +02:00
skelly37
aa8233bf1d codacy 2022-06-14 17:49:49 +02:00
skelly37
f66e47b5a0 pipe reads&sends lists now, the whole protocol is tested 2022-06-14 17:42:08 +02:00
skelly37
904824e3dc started writing test cases, app_name and app_version in pipe are forced to be str 2022-06-13 11:19:32 +02:00
skelly37
af05a324f0 unified error messages 2022-06-10 19:31:26 +02:00
skelly37
52ebce866a minor refactoring 2022-06-10 17:56:40 +02:00
skelly37
dc4e0ec63d simpler errors, useless attributes removed 2022-06-10 17:41:05 +02:00
skelly37
6f401eece9 correct pipe location on mac 2022-06-10 09:31:25 +02:00
skelly37
69b92d004f permission errors logged, better pipe creation, paths hardcoded 2022-06-09 20:26:44 +02:00
skelly37
e10d1a6d93 fixed missed comments 2022-06-08 18:08:20 +02:00
skelly37
dd548acdfb errors refactored 2022-06-08 17:40:18 +02:00
skelly37
612972385a added error classes, fixed makedirs, better args check 2022-06-08 12:52:25 +02:00
skelly37
f24793df25 removed blank lines and useless intendation 2022-06-08 09:36:38 +02:00
skelly37
dfba941125 pipe creation for *nix improved 2022-06-07 21:19:22 +02:00
skelly37
e95b47d7bf typo fix 2022-06-07 20:44:01 +02:00
skelly37
6f4de361ed sys.exit for no instance, -s argument 2022-06-07 20:35:24 +02:00
skelly37
fd48714267 unix fifo error handling & refactoring 2022-06-07 20:31:56 +02:00
skelly37
e64527a781 pipe.__generate_filename refactored for linux, added mac-specific solution 2022-06-07 19:43:34 +02:00
skelly37
6731bc6559 included suggestions for tagger.py 2022-06-07 18:55:53 +02:00
skelly37
0aba762106 reverted refactoring, added --force argument, instance creation logic 2022-06-07 14:20:57 +02:00
skelly37
e3ffd1ecd8 small suggestions included 2022-06-07 10:07:20 +02:00
skelly37
a715d332ff further refactoring 2022-06-06 20:44:50 +02:00
skelly37
72d843c52e included pipe.py 2022-06-06 12:35:03 +02:00
skelly37
3687767cf6 now commits are clean 2022-06-06 12:34:14 +02:00
Laurent Monin
b6665ce159 album.load_tracks(): move constant result test outside the loop 2022-06-05 09:23:53 +02:00
Laurent Monin
2005645b9d album.load_tracks(): reduce code redundancy
- introduce a local function _load_track()
2022-06-05 09:23:53 +02:00
Laurent Monin
df2c0da507 Merge pull request #2114 from phw/PICARD-2494-standalone-recordings-no-info
PICARD-2494: The view info dialog is not needed for NatAlbum
2022-06-03 10:33:20 +02:00
Philipp Wolfer
918120b5c8 PICARD-2494: The view info dialog is not needed for NatAlbum 2022-06-02 20:51:17 +02:00
Laurent Monin
4353f1d276 Merge pull request #2113 from phw/PICARD-2489-strxfrm-catch-oserror
PICARD-2491: Handle crash when loading albums with MBID redirect
2022-05-31 09:56:20 +02:00
Philipp Wolfer
daf6fe2412 PICARD-2491: Handle crash when loading albums with MBID redirect
After loading an album that leads to an MBID redirect _parse_result would be False, but since 8fa8bd8 this would trigger advanced relationship reload. This would trigger finalizing the loading without data being parsed.

Introduce ParseResult enum to separate the different results of parsing.
2022-05-30 21:54:20 +02:00
Philipp Wolfer
08e2328956 PICARD-2489: Handle strxfrm raising OSError
locale.strxfrm can raise OSError on some systems. Handle this gracefully to avoid Picard crashing.
2022-05-30 17:10:55 +02:00
Philipp Wolfer
a9da67e000 PICARD-2493: Ensure translation domains get used even if some translation files are missing 2022-05-30 09:02:24 +02:00
Philipp Wolfer
eb21d36d6c Release 2.8 2022-05-24 08:02:55 +02:00
Philipp Wolfer
765024d743 Build releases with PyJWT 2.4.0 2022-05-23 20:26:15 +02:00
Philipp Wolfer
9325ab4e8e README: Use HTTPS for all links 2022-05-23 10:43:19 +02:00
Philipp Wolfer
424c947706 README: Link to plugin list 2022-05-23 10:40:28 +02:00
Philipp Wolfer
a492594575 Updated translations from Transifex 2022-05-18 08:24:11 +02:00
Philipp Wolfer
a45eb53f7c Fixed NSIS template build 2022-05-12 10:39:00 +02:00
Philipp Wolfer
bf440711cb Release 2.8.0rc2 2022-05-12 10:24:03 +02:00
Philipp Wolfer
e36d415f02 NSIS: Added comment with link to NSIS language list 2022-05-12 10:05:22 +02:00
Philipp Wolfer
1f84872b67 Removed unused process_events_iter from Album._match_files
No call to Album._match_files is using use_events_iter anymore.
2022-05-12 10:03:25 +02:00
Philipp Wolfer
aacab4c176 Update translations from transifex 2022-05-12 08:39:02 +02:00
Philipp Wolfer
913325ca00 PICARD-2472: Cluster only unclustered files 2022-05-10 12:18:17 +02:00
Philipp Wolfer
bfeabb7ba8 PICARD-2475: Fix "Lookup in browser" in search dialogs
If the search in the dialog contained a MBID, the "Lookup in browser" button would attempt to load this MBID as album / recording instead of opening the browser. Now force opening in browser.
2022-05-09 13:12:11 +02:00
Philipp Wolfer
abad06a7a5 PICARD-2473: EAC log disc lookup must be available on systems without CD drive
Make the lookup disc ID action always enabled. If there is not drive make the ripper log file lookup the default.
2022-05-08 16:06:43 +02:00
Philipp Wolfer
d7b80547a4 PICARD-2470: Allow utf-16 encoded EAC log files
EAC seems to save UTF-16 encoded files. There circulate TOC files in UTF-8 encoding, but mostly these are probably the result of copy and pasting the log.

Detect the encoding based on the BOM (which for UTF-16 should always be present).
2022-05-08 12:44:45 +02:00