Laurent Monin
66c19491a3
Add a script to maintain license in source files
...
It uses existing copyrights and authors from git log.
2020-02-22 12:46:48 +01:00
Laurent Monin
a875b19792
Merge pull request #1488 from zas/tests_cleanup
...
Tests cleanup
2020-02-21 22:01:17 +01:00
Laurent Monin
3f25bda3c8
Fix a bunch of flake8 warnings, mostly cosmetic changes
2020-02-21 21:43:40 +01:00
Laurent Monin
cc84c2ee07
Merge pull request #1475 from zas/multivalue_class
...
Introduce MultiValue class to simplify script functions
2020-02-21 21:41:42 +01:00
Philipp Wolfer
a67f4327fc
PICARD-1759: Show internal tag names in TagListEditor
...
Instead of showing the display name directly show the internal tag name as it is expected for input also.
2020-02-21 20:18:40 +00:00
Philipp Wolfer
0dda97b8b8
PICARD-1759: Case-insensitive completer for TagListEditor
...
Make the completer used for TagListEditor case insensitive and always show the complete list of tags. That makes it easier for the user to see what values are expected.
2020-02-21 20:18:40 +00:00
Laurent Monin
6365295ee4
Add tests for MultiValue
...
100% coverage on the class
2020-02-21 21:04:24 +01:00
Laurent Monin
98f0bcebc8
MultiValue: remove assert statement to please Codacy
...
It shouldn't be needed anyways
2020-02-21 20:39:41 +01:00
Laurent Monin
18c02c605d
MultiValue: get rid of _get_multi_values() and simplify code even more
2020-02-21 20:39:41 +01:00
Laurent Monin
ce0f9c159d
MultiValue: simplify code
2020-02-21 20:39:41 +01:00
Laurent Monin
32dd385aec
MultiValue: add __str__() method, returning joined string
...
It uses MultiValue.separator as join string
2020-02-21 20:39:41 +01:00
Laurent Monin
9ca390b8d3
Stick to Data Model names (index -> key)
2020-02-21 20:39:41 +01:00
Laurent Monin
c83a045639
Name multi values consistently
2020-02-21 20:39:40 +01:00
Laurent Monin
800c8abcca
Use MultiValue.separator to simplify code
2020-02-21 20:39:40 +01:00
Laurent Monin
b16f2099a7
func_lenmulti(): no need to call func_len()
2020-02-21 20:39:40 +01:00
Laurent Monin
1cec6e3e06
Replace _get_multi_values() with MultiValue()
2020-02-21 20:39:40 +01:00
Laurent Monin
6992b271c3
Add MultiValue class to handle script multi-values
2020-02-21 20:39:40 +01:00
Laurent Monin
9dfc09b4c4
Bump github actions checkout to v2
...
It seems much less prone to failures
2020-02-21 19:35:38 +00:00
Laurent Monin
0860e1db15
Merge pull request #1486 from zas/scriptfunctions_cov
...
Improve script functions test coverage
2020-02-20 22:50:17 +01:00
Philipp Wolfer
b40a3cb9cd
PICARD-1756: Fix plugin update version comparison
...
Use Version class to implement version comparison. Fixes updater considering 1.10 < 1.9
2020-02-20 21:18:07 +00:00
Laurent Monin
6f9b171d1c
Test script_function decorator
...
Changes were made to ensure ScriptParser registry is resetted on each test
2020-02-20 21:54:06 +01:00
Laurent Monin
ccf6edfbd9
Complete multi functions tests
2020-02-20 21:06:09 +01:00
Laurent Monin
037a487710
$title: test all cases, and drop test for empty text which cannot happen
2020-02-20 21:06:09 +01:00
Laurent Monin
37631e8ad7
$rsearch: test unmatched regex
2020-02-20 21:06:09 +01:00
Laurent Monin
5b1cfc5470
$div: test non-numeric parameter
2020-02-20 21:06:09 +01:00
Laurent Monin
665a3e9885
$div: Test and handle division by zero error
2020-02-20 21:06:09 +01:00
Laurent Monin
55ad8a3924
Test various unknown functions and unexpected script errors
2020-02-20 21:06:09 +01:00
Laurent Monin
0da4ab5d74
Tidy up script tests
...
Remove useless whitespaces
Fix typo in comment
test_optional_kwonly_parameters(): self is unused -> static method
Use raw string notation
2020-02-20 20:53:02 +01:00
Philipp Wolfer
265ed0775e
PICARD-1755: Specify available languages for Windows Store.
...
For now limit this to the languages for which there is also a localized store page (which is based on completion of translating the appstream data).
2020-02-20 18:22:16 +00:00
Philipp Wolfer
3ffa21eb08
PICARD-1754: Removed QKeySequence.Delete shortcut for remove action
...
This reverts 84d8341 . QKeySequence.Delete is still used for item removal on the itemview and metadatabox panes (see MainWindow.keyPressEvent). But if this action is registered globally item removal interfers with removing elements from MetadataBox.
2020-02-20 15:17:41 +00:00
Philipp Wolfer
12f1452c96
PICARD-1750: Add AcoustID fingerprint from tags to AcoustIDManager
...
If a file has an existing AcoustID fingerprint in its tags and ignore_existing_acoustid_fingerprints is not set, then use this fingerprint to properly initialize the AcoustIDManager. This makes the existing fingerprint available for submission.
Previously such a file would not have its fingerprint used even after a Scan.
2020-02-20 07:29:51 +00:00
Philipp Wolfer
7e350da299
Refactor File to handle acoustid_fingerprint
...
acoustid_fingerprint is now a normal attribute of File and always available. Adding and removing the file to and from the AcoustIDManager is now completely handled in File.
2020-02-20 07:29:51 +00:00
Philipp Wolfer
800f61e6b6
PICARD-1752: Use the first matching preferred release country
...
For releases with multiple release countries use the first matching preferred release country for %releasecountry%.
2020-02-19 21:55:23 +00:00
Philipp Wolfer
7539d8dc23
PICARD-1751: Provide a ~releasecountries variable
2020-02-19 21:55:23 +00:00
Laurent Monin
fd25dc987d
PICARD-1748: limit number of countries displayed to 10
2020-02-19 20:11:58 +00:00
Philipp Wolfer
04a771a2f9
macOS: Set LSMinimumSystemVersion based on MACOSX_DEPLOYMENT_TARGET
2020-02-17 23:56:41 +01:00
Philipp Wolfer
b029eb8374
PICARD-1745: Set MACOSX_DEPLOYMENT_TARGET to 10.12
...
Attempt to build a libdiscid compatible with macOS 10.12
2020-02-17 23:55:11 +01:00
Philipp Wolfer
3de8ee49a1
Release 2.3
2020-02-17 21:04:51 +01:00
Philipp Wolfer
ea99e4d294
Updated translations
2020-02-17 20:51:18 +01:00
Philipp Wolfer
a33133b13e
PICARD-1744: Fixed crash on invalid ignore_regex
2020-02-16 18:58:21 +01:00
Philipp Wolfer
4027eeafff
Added German with Swiss ortography
...
de_CH does not seem to be supported on Transifex, but the differences to German (Germany) are small. The de_CH.po only contains the strings with differences, gettext will automatically fallback to "de" for the rest.
2020-02-15 14:23:10 +01:00
Bob Swift
6683dcf891
Remove unnecessary 'try' block from $slice function
2020-02-14 08:16:02 +01:00
Laurent Monin
f3ca11c161
Merge pull request #1471 from zas/translate_nsh_french
...
French translation for installer (.nsh)
2020-02-13 16:42:31 +01:00
Laurent Monin
4b2bfc2b5a
Minor French installer translation fixes
2020-02-12 22:33:15 +01:00
Laurent Monin
2aafa0f5e8
Enable French language for installer
2020-02-12 18:21:16 +01:00
Laurent Monin
cd295cf8e2
Merci de -> veuillez
...
Suggested by trebmuh
2020-02-12 17:29:43 +01:00
Laurent Monin
94b1628533
French translation for installer (.nsh)
2020-02-12 16:28:45 +01:00
Philipp Wolfer
a9b16c2578
PICARD-1740: Store originalfilename to ASF as WM/OriginalFilename
...
See also:
- http://msdn.microsoft.com/en-us/library/ms867702.aspx
- https://help.mp3tag.de/main_tags.html
2020-02-11 23:46:55 +01:00
Philipp Wolfer
c018f076ea
PICARD-1739: Use new Version class for version comparison in update check
...
Fixes update check not properly comparing alpha, beta and rc releases.
2020-02-11 23:03:20 +01:00
Philipp Wolfer
12e8e20906
Fixed typo in changelog
2020-02-11 20:51:00 +01:00