Commit Graph

5407 Commits

Author SHA1 Message Date
Philipp Wolfer
8a4ceded69 Refactor: More DRY formats implementations 2018-09-13 18:23:48 +02:00
Laurent Monin
b0217ee946 Simplify sortable/non-sortable __lt__() 2018-09-13 17:54:13 +02:00
Laurent Monin
16a3074be4 PEP8 fixes 2018-09-13 17:54:13 +02:00
Laurent Monin
09d1551a61 PICARD-518: Add a tip to sliders in Options > Metadata > Preferred Releases
- Display a tip with actual value
- 5 by 5 step (values from 0 to 100)
- page step (keyboard only set to 25)
2018-09-13 14:10:00 +02:00
Sambhav Kothari
660494fef2 Merge pull request #966 from zas/pyinstaller_3.4_fix
Fix pyinstaller complaining about empty DEST
2018-09-12 22:14:05 +01:00
Laurent Monin
888249de97 Fix pyinstaller complaining about empty DEST
It is enforced by pyinstaller 3.4

Empty DEST not allowed when adding binary and data files. Maybe you want to used '.'.
Caused by 'discid.dll'.

https://github.com/pyinstaller/pyinstaller/issues/3066
2018-09-12 15:45:43 +02:00
Philipp Wolfer
d034e5c6fa PICARD-1339: Remove O(n^2) complexity when deleting files
This change basically makes sure calls to update_metadata_images are done only once per cluster / track when multiple files get removed. Since update_metadata_images iterates over all files inside a cluster doing this after deletion reduces the complexity significantly.
2018-09-08 16:06:51 +02:00
Laurent Monin
c2437c412b Warn about deprecated string_() and convert_to_string() 2018-09-08 15:48:24 +02:00
Laurent Monin
63f71354b1 Improve code in _move_additional_files(), drop extra loops 2018-09-08 15:48:24 +02:00
Laurent Monin
683b934685 Drop use of string_(), deprecated 2018-09-08 15:48:24 +02:00
Laurent Monin
442f2883e5 PICARD-1340: fix display of Mono/Stereo for channels in info dialog
ch is a string
2018-09-08 15:09:42 +02:00
Philipp Wolfer
97bd392844 PICARD-1112: Clear deleted tags after saving file 2018-09-07 13:18:19 +02:00
Philipp Wolfer
8586bf95da PICARD-105: Allow loading AcoustId recording as NAT
For NAT recordings AcoustId returns incomplete results and we have only the recording ID. Allow Picard to load such results as NAT.
2018-09-07 10:55:58 +02:00
Philipp Wolfer
0791312e5c Merge pull request #962 from phw/PICARD-1268-support-concertmaster-relationship
PICARD-1268: Load concertmaster as performer:concertmaster
2018-09-06 16:51:23 +02:00
Philipp Wolfer
9bd2e9418d Merge pull request #959 from phw/PICARD-1336-mp4-set-bool-tags-supported
PICARD-1336: For MP4 integer tags were not marked as supported
2018-09-06 16:51:04 +02:00
Philipp Wolfer
28d473b630 PICARD-1268: Load concertmaster as performer:concertmaster 2018-09-06 16:11:43 +02:00
Philipp Wolfer
8a8fbc143c Syntax fix 2018-09-06 16:11:14 +02:00
Philipp Wolfer
cdcd6db7e2 Sort mapping lists in mbjson alphabetically 2018-09-06 16:07:03 +02:00
Philipp Wolfer
6d679e9e46 Merge pull request #954 from phw/PICARD-1332-restore-deleted-file-tags
PICARD-1332: When unmatching a file restore deleted tags from origina…
2018-09-06 14:16:17 +02:00
Philipp Wolfer
cb0f391c12 PICARD-1336: For MP4 integer tags were not marked as supported 2018-09-06 14:12:47 +02:00
Philipp Wolfer
72e12aba3a Merge pull request #957 from zas/fix_isort_init_py
Fix isort config to not skip __init__.py files (but few)
2018-09-05 18:09:13 +02:00
Laurent Monin
9bdc435dcb Clean-up imports with the help of isort 2018-09-05 17:39:25 +02:00
Laurent Monin
8840825111 Unexpectedly, isort skips __init__.py by default
See https://github.com/timothycrosley/isort/issues/690

Include all __init__.py but make exceptions for const/__init__.py and formats/__init__.py
2018-09-05 17:39:25 +02:00
Laurent Monin
7ecf0db753 Merge pull request #956 from phw/PICARD-1245-fix-mutagen-3.7
PICARD-1245: GRP1 tag compatibility for mutagen 1.37
2018-09-05 17:38:59 +02:00
Laurent Monin
376c5f396f Merge branch 'master' into PICARD-1245-fix-mutagen-3.7 2018-09-05 16:51:14 +02:00
Philipp Wolfer
52827ae058 PICARD-875: Make compatid3 tags available to AIFF and DSF 2018-09-05 14:41:27 +02:00
Philipp Wolfer
f9329c1856 PICARD-1245: GRP1 tag compatibility for mutagen 1.37 2018-09-05 14:40:39 +02:00
Philipp Wolfer
edb9730dcf PICARD-1333 Travis: Test against oldest supported mutagen version 2018-09-05 14:37:47 +02:00
Laurent Monin
f681cb43ac Update NEWS.txt 2018-09-05 10:38:11 +02:00
Philipp Wolfer
e02b9d80fa CI: Fixed branch regex 2018-09-05 10:30:46 +02:00
Laurent Monin
91546e0fe9 Bump version to 2.0.5dev1 2018-09-05 10:25:44 +02:00
Philipp Wolfer
4de0f9de5e CI: Build release branches
This will build branches like 1.4.x, 2.0.x, 2.x, 2.1
2018-09-05 09:37:48 +02:00
Laurent Monin
db3bae8ba2 Merge branch 'master' into PICARD-1332-restore-deleted-file-tags 2018-09-05 09:05:27 +02:00
Laurent Monin
832c6d98aa Merge pull request #945 from phw/PICARD-1328-fix-load-optimfrog
PICARD-1328: Fix loading OptimFROG files
2018-09-05 09:03:40 +02:00
Laurent Monin
8fd1a62abe Merge branch 'master' into PICARD-1328-fix-load-optimfrog 2018-09-05 08:51:21 +02:00
Philipp Wolfer
4137f631e1 PICARD-1331: Fix crash when plugin installation fails 2018-09-05 08:47:01 +02:00
Laurent Monin
63d61c7830 Merge branch 'master' into PICARD-1328-fix-load-optimfrog 2018-09-05 08:38:53 +02:00
Philipp Wolfer
cc93a2a45f PICARD-1332: Deleted tags on tracks get applied to matched files 2018-09-05 08:33:19 +02:00
Philipp Wolfer
c9a30345f8 PICARD-1332: When unmatching a file restore deleted tags from original metadata 2018-09-05 08:32:36 +02:00
Philipp Wolfer
870b159e22 Added unit tests for APE, ASF, Opus and Speex formats 2018-09-04 11:33:09 +02:00
Laurent Monin
2ca680926d Merge pull request #947 from phw/PICARD-1329-fix-saving-itunnorm
PICARD-1329: Fix saving iTunNORM tags to ID3
2018-09-04 09:40:16 +02:00
Philipp Wolfer
182ea65b3f PICARD-1328: Fix OptimFROG format detection 2018-09-04 08:47:03 +02:00
Philipp Wolfer
4c20e811cf PICARD-1329: Fix saving iTunNORM tags to ID3 2018-09-04 07:46:14 +02:00
Philipp Wolfer
9c649d97f0 PICARD-1328: Fix loading OptimFROG files 2018-09-03 23:26:53 +02:00
Laurent Monin
4d8a5621e4 Merge pull request #944 from phw/PICARD-1327-fix-load-tak
PICARD-1327: Fix loading TAK files
2018-09-03 18:19:52 +02:00
Philipp Wolfer
0e55d039c1 PICARD-1327: Fix loading TAK files 2018-09-03 17:42:12 +02:00
Laurent Monin
c09aec04fc Merge pull request #943 from phw/PICARD-1326-preserve-waveformatextensible-channel-mask
PICARD-1326: FLAC: Preserve waveformatextensible_channel_mask when clearing tags
2018-09-03 16:38:28 +02:00
Philipp Wolfer
30895eedd6 FLAC: Preserve waveformatextensible_channel_mask when clearing tags
Fixes PICARD-1326
2018-09-03 15:07:57 +02:00
Philipp Wolfer
9c628ea47b PICARD-1216: Do not allocate new console 2018-09-01 11:26:03 +02:00
Philipp Wolfer
f215d99960 PICARD-1216: Attempt to attach to console on Windows 2018-09-01 11:26:03 +02:00