fergalmoran/picard
1
0
Fork 0
mirror of https://github.com/fergalmoran/picard.git synced 2026-02-24 08:33:59 +00:00
Code Issues Packages Projects Releases Wiki Activity
4,955 Commits 1 Branch 0 Tags
abad70215e04b3a5bb03bca02ca2cc89be2dcfca
Commit Graph

4955 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Laurent Monin
abad70215e Merge pull request #805 from zas/search_edit_optional 
SearchDialog: make search edit box at top optional
 2018-01-21 13:41:33 +01:00
Laurent Monin
b792da9799 SearchDialog: make search edit box at top optional 
It will ease reusing this album selector for disambiguation
 2018-01-21 11:31:07 +01:00
Laurent Monin
1403e13e54 Merge pull request #803 from zas/search_dialog_states 
Simplify search dialog save/restore states code
 2018-01-20 15:31:56 +01:00
Laurent Monin
2af8c683b4 Do not save table header state on resize 
It causes a call for each column, better to only save when exiting the dialog (already done)
 2018-01-20 11:33:56 +01:00
Laurent Monin
c4e1c2584d Move save/restore state methods to parent class SearchDialog 
Reduce code redundancy
Log save/restore actions to debug log
 2018-01-20 11:32:27 +01:00
Laurent Monin
f006a5bd76 Merge pull request #801 from zas/cd_lookup 
Only output CD read failure traceback in debug mode
 2018-01-19 11:10:27 +01:00
Laurent Monin
ad6bcb49d0 Merge branch 'master' into cd_lookup 2018-01-19 10:46:50 +01:00
Sambhav Kothari
790a1d619a Merge pull request #802 from mineo/length-score-tests 
Fix length_score and add tests
 2018-01-19 02:03:11 +05:30
Wieland Hoffmann
c18ae092ba Fix length_score and add tests 
In 2f8496e, 1.0 - ... turned into 0.0. Fix that.
 2018-01-18 20:58:32 +01:00
Laurent Monin
b4d9d32dee Only output CD read failure traceback in debug mode 
It makes the log cleaner, as most of times CD read error is due to CD not inserted.

Without debug mode, output looks like:

```
E: 16:58:00 Error while reading b'/dev/sr1': cannot open device `/dev/sr1'
```

With debug mode:

```
D: 16:58:17 Reading CD using device: b'/dev/sr1'
E: 16:58:17 Error while reading b'/dev/sr1': cannot open device `/dev/sr1'
E: 16:58:17 Traceback (most recent call last):
  File "./picard/util/thread.py", line 47, in run
    result = self.func()
  File "./picard/disc.py", line 55, in read
    raise e
  File "./picard/disc.py", line 50, in read
    disc = discid.read(device)
  File "/home/zas/.virtualenvs/picard2/lib/python3.5/site-packages/discid/disc.py", line 55, in read
    disc.read(device, features)
  File "/home/zas/.virtualenvs/picard2/lib/python3.5/site-packages/discid/disc.py", line 152, in read
    raise DiscError(self._get_error_msg())
discid.disc.DiscError: cannot open device `/dev/sr1'
```
 2018-01-18 17:11:02 +01:00
Laurent Monin
cf538b5102 Merge pull request #800 from zas/fix_tab_stops 
Re-define or set tabstops to improve keyboard navigation through options
 2018-01-18 17:05:37 +01:00
Laurent Monin
382dff8bc9 Merge branch 'master' into fix_tab_stops 2018-01-18 16:29:29 +01:00
Laurent Monin
cbb8685b3e Merge pull request #799 from zas/PICARD-1174 
[PICARD-1174] Add an option to control the tolerance of track times difference
 2018-01-18 14:30:55 +01:00
Laurent Monin
d37555d3ed [PICARD-1174] Add an option to tolerate differences in track times 
The option `ignore_track_duration_difference_under` can be set through Advanced options panel.
If old and new Length tag have a difference under this value, they are considered equal, and this isn't accounted as a track difference.
 2018-01-18 13:28:31 +01:00
Laurent Monin
9bdd48f7b3 Re-define or set tabstops to improve keyboard navigation through options 2018-01-18 13:24:50 +01:00
Laurent Monin
1457fb850b Merge pull request #797 from zas/cmp_duration 
Minor code cleanup, related to track durations/lengths
 2018-01-17 21:34:42 +01:00
Sambhav Kothari
ea5f969427 Merge branch 'master' into cmp_duration 2018-01-18 01:35:48 +05:30
Laurent Monin
e1709215fe Merge pull request #798 from zas/fix_length_edit 
Fix removal of ~length from sets, incorrect single-element tuple syntax
 2018-01-17 20:16:42 +01:00
Laurent Monin
4e40e7fa07 _update_items(): remove useless intermediate variable 2018-01-17 20:14:38 +01:00
Laurent Monin
2f8496e0c5 Introduce length_score() and document it a bit, reducing code redundancy 2018-01-17 20:14:38 +01:00
Laurent Monin
01c5437a27 Fix removal of ~length from sets, incorrect single-element tuple syntax 
The `discard` argument is expected to be a sequence, but the syntax `discard=('elem')` is equivalent to `discard='elem'`.
A trailing comma is needed in this case: `discard=('elem',)` so discard is actually a tuple with a single element.
 2018-01-17 15:15:38 +01:00
Sambhav Kothari
ee08a43102 Merge pull request #793 from samj1912/prtemp 
Add a PR template
 2018-01-08 20:05:20 +05:30
Sambhav Kothari
c63d24e54c Merge branch 'master' into prtemp 2018-01-08 19:54:21 +05:30
Sambhav Kothari
84e0705b58 Merge pull request #794 from mineo/picard-1171 
PICARD-1171: Make it possible to select the text in "About"
 2018-01-04 04:50:21 +05:30
Wieland Hoffmann
3ba4016bd0 PICARD-1171: Make it possible to select the text in "About" 
This allows to easily copy the version information to tickets.
 2018-01-03 18:50:16 +01:00
Sambhav Kothari
576dd44ed6 Add a PR template 2017-12-23 02:49:35 +05:30
Sambhav Kothari
ec07112bbd Fix NameError due to variable rename 2017-12-22 19:42:07 +05:30
Sambhav Kothari
3e8d0b0efa Merge pull request #730 from Sophist-UK/PICARD-1085_fix-multi-dir-load-on-windows 
PICARD-1085: Fix multi-directory load on Windows
 2017-12-17 00:41:34 +05:30
Sophist
743575b778 Fix multi-directory load on Windows 
On Windows on Qt5 it appears you need to avoid native dialog.

As far as I can tell, this was actually a bug under Qt4 (because native
dialog wasn't used anyway) and it should always have been specified.

I have only added win32 to the exception list. This may be required on
all platforms, but I am unable to test this.
 2017-12-17 00:37:05 +05:30
Sambhav Kothari
9082889dbc Merge pull request #619 from Sophist-UK/distinguish-between-unclustered-unmatched-files 
PICARD-978: Distinguish between unclustered unmatched files
 2017-12-17 00:31:39 +05:30
Sophist
fac3c3ee31 Merge branch 'master' into distinguish-between-unclustered-unmatched-files 2017-12-15 09:50:20 +00:00
Sambhav Kothari
ebcd87bab2 Merge pull request #792 from dseomn/picard-1123-multiple-languages 
PICARD-1123: Multiple work languages are collapsed
 2017-12-14 03:59:45 +05:30
David Mandelberg
429867501c PICARD-1123: Multiple work languages are collapsed 
If the server provides multiple languages, use all of them. Otherwise, fall
back to the single language field.
 2017-12-13 15:42:42 -05:00
Sambhav Kothari
0e430d50f0 Merge pull request #791 from paulroub/PICARD-1161-accept-chrome-images 
Accept dragged images from Google Chrome
 2017-12-12 22:32:36 +05:30
Sambhav Kothari
5315308100 Merge branch 'master' into PICARD-1161-accept-chrome-images 2017-12-12 22:24:18 +05:30
Sambhav Kothari
0aadf5dc53 Merge pull request #790 from mineo/picard-1159 
PICARD-1159: Don't pass filenames as bytes to wave.open
 2017-12-10 00:46:09 +05:30
Sambhav Kothari
35018c388f Merge branch 'master' into picard-1159 2017-12-10 00:41:16 +05:30
Paul Roub
c8104ccbc4 Accept dragged images from Google Chrome 
On macOS, at least, images dragged from Chrome are rejected (there's no
octet stream data to be found).  Using the x-qt-image data instead --
only when the previously-used methods have failed.
 2017-12-08 12:54:59 -05:00
Wieland Hoffmann
5dad06efe4 Merge pull request #789 from phw/handle-plugin-symlinks-on-update 
Handle upgrade of plugin directories being symlinks
 2017-12-06 19:31:54 +01:00
Wieland Hoffmann
8490422384 PICARD-1159: Don't pass filenames as bytes to wave.open 
wave.open treats everything that's not a str as a file-like object.
encode_filename returns bytes, but they're not file-like.
 2017-12-06 19:19:34 +01:00
Philipp Wolfer
949619751e Handle upgrade of plugin directories being symlinks 
Fixes PICARD-1156
 2017-11-27 12:57:07 +01:00
Sambhav Kothari
bcd58b513d Merge pull request #788 from metabrainz/picard1148 
PICARD-1148: Fix ValueError due to change from XML to JSON
 2017-11-12 22:28:41 +05:30
Sambhav Kothari
d9ed69dc6b PICARD-1148: Fix ValueError due to change from XML to JSON 2017-11-11 16:22:11 +05:30
Sambhav Kothari
c2f228269c Merge pull request #785 from Sophist-UK/picard-1143_always-hide-.smbdelete-files 
PICARD-1143: Prevent loading .smbdelete* files
 2017-10-23 23:39:06 +05:30
Sambhav Kothari
edd62be252 Merge branch 'master' into picard-1143_always-hide-.smbdelete-files 2017-10-23 23:13:58 +05:30
Sophist
acf0482c07 Refine comment very slightly 2017-10-23 15:33:36 +01:00
Sophist
5cc8fea2c4 Add explanatory comment and disregard hidden status to address review comments 2017-10-23 15:32:21 +01:00
Sambhav Kothari
5c9890f409 Merge pull request #786 from mineo/picard-1147 
PICARD-1147: Handle media with only data tracks
 2017-10-19 02:13:05 +05:30
Wieland Hoffmann
934fe93489 PICARD-1147: Handle media with only data tracks 
In the JSON representation, these media do not have a 'tracks' element
containing the list of tracks.
 2017-10-18 18:33:09 +02:00
Laurent Monin
9b0b3dbaa9 Merge pull request #784 from samj1912/picard1142 
PICARD-1142: Fix crash on CD lookup
 2017-10-05 08:59:11 +02:00