Commit Graph

6926 Commits

Author SHA1 Message Date
Philipp Wolfer
b63a35296a Adapt capitalization of "Generate AcoustID Fingerprints"
Use same capitalization as in other actions.
2020-02-03 18:02:23 +01:00
Philipp Wolfer
d653270b71 PICARD-1723: Consider disc number when comparing metadata
Improves results when matching files to multi-disc albums.
2020-02-03 11:16:52 +01:00
Laurent Monin
793aff31fb Merge pull request #1453 from zas/fix_script_func_names
Unify new and old script function names
2020-02-01 19:22:00 +01:00
Laurent Monin
56a6debd1e Introduce script_function() decorator
It simplifies script functions registration a lot, especially with a constant naming scheme
2020-02-01 18:21:16 +01:00
Laurent Monin
52b80593ac Unify new and old script function names
Before introduction of new functions, we had a pattern: "name" script function was defined by "func_name"
Recent patches changed this, introducing inconsistencies.
Also we have inmulti and lenmulti, so stick to this scheme for getmulti and others.

func_find_str -> func_find
find_str -> find
func_reverse_str -> func_reverse
reverse_str -> reverse
func_get_multi -> func_getmulti
func_foreach_multi -> func_foreach
func_while_loop -> func_while
func_map_multi -> func_map
2020-02-01 18:07:38 +01:00
Philipp Wolfer
3d2a5cf250 PICARD-1719: Fix $unset must not mark tags for deletion.
This regressed in Picard 2.2.0 with commit 503b520 and $unset behaves the same as $delete.
2020-01-31 18:09:07 +01:00
Philipp Wolfer
93b15b8868 Merge pull request #1448 from rdswift/script_functions
PICARD-1716: Add script functions for strings, multi-value variables, and loops
2020-01-31 18:08:39 +01:00
Bob Swift
dc60e09034 Remove unneeded loop count initialization. 2020-01-31 08:37:03 -07:00
Bob Swift
0bea47fcdf Add tests on missing inputs. 2020-01-31 08:20:58 -07:00
Bob Swift
7b05c54e42 Tighten code in loops. Update docstrings. 2020-01-31 08:20:22 -07:00
Philipp Wolfer
524a006ee6 PICARD-1717: Use version specific config file if it exists 2020-01-31 14:20:59 +01:00
Philipp Wolfer
590470e939 PICARD-1717: On update create a copy of the existing config file 2020-01-31 14:20:59 +01:00
Philipp Wolfer
26773b4af2 Use PICARD_ORG_NAME for config location
This does not actually change the location, but makes the setup consistent with e.g. the config file configuration in config.py.
2020-01-31 14:16:51 +01:00
Bob Swift
debe835ab0 Use enumerate() for multi-value loops. Move runaway test initialization. 2020-01-30 20:12:29 -07:00
Bob Swift
c91e797170 Correct codacy issue regarding type checking. 2020-01-30 19:39:08 -07:00
Bob Swift
9ac7fd290b Add tests for new functions. 2020-01-30 19:31:41 -07:00
Bob Swift
70864210d4 Updated docstrings, variables, function names. Added ValueError check. 2020-01-30 19:31:13 -07:00
Philipp Wolfer
66a1b7822b Release 2.3.0b1 2020-01-30 14:05:16 +01:00
Philipp Wolfer
f6601079bf Updated translations from Transifex 2020-01-30 13:26:12 +01:00
Philipp Wolfer
78e8115a5d CI: Do not upload artifact if signed Windows app was not built 2020-01-30 09:04:12 +01:00
Bob Swift
2bd872dc89 Add script functions
Add 'find' substring within string
Add string 'reverse'
Add 'substr' to extract a substring from a string
Add 'get_multi_item' to get an element from a multi-value variable
Add 'foreach' to loop through each item in a multi-value variable
Add 'for' loop
Add 'while' loop
2020-01-29 18:19:27 -07:00
Philipp Wolfer
a9cb192f00 PICARD-1646: Consider release types for AcoustId results
Make the release primary and secondary type as provided by AcoustId available to the matching.
2020-01-29 19:25:36 +01:00
Philipp Wolfer
6879be9ccb Merge pull request #1446 from phw/ci-split-windows-builds
CI: split windows builds into separate jobs
2020-01-29 09:50:41 +01:00
Philipp Wolfer
25c1f874c9 CI: Use a single package workflow to build and release
Allows creating the release in one go, avoids release data getting overwritten by different jobs
2020-01-29 09:40:01 +01:00
Philipp Wolfer
a8da256764 CI: Use build matrix to simplify Windows build setup 2020-01-29 09:08:56 +01:00
Philipp Wolfer
84e6322bc3 CI: Split building Windows packages into separate jobs
Upload separate artifacts and build in parallel.
2020-01-29 08:31:26 +01:00
Philipp Wolfer
3691d94cea Merge pull request #1444 from phw/PICARD-1715-script-change-file-ext
PICARD-1715: Allow changing file extension in renaming script
2020-01-28 16:35:46 +01:00
Philipp Wolfer
162d081af5 Simplified handling of dot in filename extension 2020-01-28 16:16:34 +01:00
Philipp Wolfer
d569706c8b CODE_OF_CONDUCT.md: actually link to the CoC
Render the link as a clickable link instead of as code
2020-01-28 16:07:27 +01:00
Philipp Wolfer
e69ab0cfe1 PICARD-1682: Fix multiline editing for lyrics:{desc} tags 2020-01-28 15:34:52 +01:00
Philipp Wolfer
9b3597ef2c CONTRIBUTING: Fixed link to Google-style docstrings 2020-01-28 15:31:22 +01:00
Philipp Wolfer
1799011eb6 PICARD-1715: Add new script_to_filename_with_metadata function
Keep existing script_to_filename function with same behavior as before
2020-01-28 15:14:47 +01:00
Philipp Wolfer
bcc81d86eb PICARD-1715: Allow changing file extension in renaming script 2020-01-28 13:41:27 +01:00
Laurent Monin
5238440076 Bokmal -> Bokmål
https://en.wikipedia.org/wiki/Bokm%C3%A5l
2020-01-28 12:16:10 +01:00
Laurent Monin
95ac29d973 kaj_NG locale name is missing parenthesis around country suffix 2020-01-27 19:27:18 +01:00
Laurent Monin
88cb05f1fc Resync pot file 2020-01-27 12:28:43 +01:00
Laurent Monin
f506ae303a Update translation files 2020-01-27 12:28:09 +01:00
Philipp Wolfer
ab5aa68b4f Use standard key sequences instead of custom checks in keyPressEvent.
Ensures platform specific shortcuts are used.
2020-01-26 18:24:32 +01:00
Philipp Wolfer
8f693aaf4d PICARD-1714: Use standard search shortcut to focus search input 2020-01-26 17:30:39 +01:00
Philipp Wolfer
c52519d91a PICARD-239: Handle tags like "comment" and "comment:" the same
Some of Picard's tag names allow an additional description separated by a colon, e.g. "comment:desc". In case the description part is empty and the tag ends on a colon this is now treated the same as without any colon. So "lyrics" and "lyrics:" are the same tag.

Handling this in Metadata makes this change immediately available in scripting and to all formats. Script using both forms will still work.
2020-01-26 17:07:42 +01:00
Philipp Wolfer
58ffb1a763 Update picard.pot 2020-01-26 17:03:21 +01:00
Philipp Wolfer
133404dd26 Merge pull request #1440 from zas/remove_shortcut
PICARD-1712: use QtGui.QKeySequence.Delete for remove albums/files shortcut
2020-01-26 08:06:47 +01:00
Laurent Monin
e3c7e18829 Use Ctrl+G shortcut instead of Ctrl+E for View Log action 2020-01-25 19:33:59 +01:00
Laurent Monin
84d83417a3 PICARD-1712: use QtGui.QKeySequence.Delete for remove albums/files shortcut 2020-01-25 17:31:05 +01:00
Laurent Monin
8b944984c1 Set Add Folder accelerator & shortcut to e and Ctrl+E
Reason: Ctrl+D is usually associated with Delete action, see https://doc.qt.io/qt-5/qkeysequence.html
2020-01-25 17:25:22 +01:00
Philipp Wolfer
fba431521f Added Dutch countries translation 2020-01-24 10:48:19 +01:00
Philipp Wolfer
a53e12d54e Updated translations from Transifex 2020-01-24 10:46:01 +01:00
Philipp Wolfer
d67973c936 Set StartupWMClass in .desktop file again
The Ubuntu / GNOME dock otherwise does not properly detect the correct .desktop entry. The name is the same that is used for the QApplication application name (PICARD_APP_NAME).
2020-01-23 19:43:13 +01:00
Laurent Monin
aefbdb6a73 Move more code from Metadata to external small functions, test them 2020-01-23 18:01:28 +01:00
Laurent Monin
210e71b426 Pass parts to weights_from_release_type_scores() 2020-01-23 18:01:28 +01:00