Commit Graph

9013 Commits

Author SHA1 Message Date
Philipp Wolfer
bb07ff7f41 PICARD-2498: Added test for PluginsOptionsPage.link_authors 2022-06-08 21:16:57 +02:00
Philipp Wolfer
51bbbf362a PICARD-2498: Link plugin authors with e-mail using mailto: 2022-06-07 18:12:18 +02:00
Philipp Wolfer
fdb9752147 PICARD-2498: HTML escape plugin metadata before display 2022-06-07 17:56:51 +02:00
Philipp Wolfer
04ddb9f3f0 Release 2.8.1 2022-06-07 08:10:30 +02:00
Philipp Wolfer
3dcaf0ccdf Updated translations from transifex 2022-06-07 08:00:29 +02:00
Laurent Monin
b6665ce159 album.load_tracks(): move constant result test outside the loop 2022-06-05 09:23:53 +02:00
Laurent Monin
2005645b9d album.load_tracks(): reduce code redundancy
- introduce a local function _load_track()
2022-06-05 09:23:53 +02:00
Laurent Monin
df2c0da507 Merge pull request #2114 from phw/PICARD-2494-standalone-recordings-no-info
PICARD-2494: The view info dialog is not needed for NatAlbum
2022-06-03 10:33:20 +02:00
Philipp Wolfer
918120b5c8 PICARD-2494: The view info dialog is not needed for NatAlbum 2022-06-02 20:51:17 +02:00
Laurent Monin
4353f1d276 Merge pull request #2113 from phw/PICARD-2489-strxfrm-catch-oserror
PICARD-2491: Handle crash when loading albums with MBID redirect
2022-05-31 09:56:20 +02:00
Philipp Wolfer
daf6fe2412 PICARD-2491: Handle crash when loading albums with MBID redirect
After loading an album that leads to an MBID redirect _parse_result would be False, but since 8fa8bd8 this would trigger advanced relationship reload. This would trigger finalizing the loading without data being parsed.

Introduce ParseResult enum to separate the different results of parsing.
2022-05-30 21:54:20 +02:00
Philipp Wolfer
08e2328956 PICARD-2489: Handle strxfrm raising OSError
locale.strxfrm can raise OSError on some systems. Handle this gracefully to avoid Picard crashing.
2022-05-30 17:10:55 +02:00
Philipp Wolfer
a9da67e000 PICARD-2493: Ensure translation domains get used even if some translation files are missing 2022-05-30 09:02:24 +02:00
Philipp Wolfer
eb21d36d6c Release 2.8 2022-05-24 08:02:55 +02:00
Philipp Wolfer
765024d743 Build releases with PyJWT 2.4.0 2022-05-23 20:26:15 +02:00
Philipp Wolfer
9325ab4e8e README: Use HTTPS for all links 2022-05-23 10:43:19 +02:00
Philipp Wolfer
424c947706 README: Link to plugin list 2022-05-23 10:40:28 +02:00
Philipp Wolfer
a492594575 Updated translations from Transifex 2022-05-18 08:24:11 +02:00
Philipp Wolfer
a45eb53f7c Fixed NSIS template build 2022-05-12 10:39:00 +02:00
Philipp Wolfer
bf440711cb Release 2.8.0rc2 2022-05-12 10:24:03 +02:00
Philipp Wolfer
e36d415f02 NSIS: Added comment with link to NSIS language list 2022-05-12 10:05:22 +02:00
Philipp Wolfer
1f84872b67 Removed unused process_events_iter from Album._match_files
No call to Album._match_files is using use_events_iter anymore.
2022-05-12 10:03:25 +02:00
Philipp Wolfer
aacab4c176 Update translations from transifex 2022-05-12 08:39:02 +02:00
Philipp Wolfer
913325ca00 PICARD-2472: Cluster only unclustered files 2022-05-10 12:18:17 +02:00
Philipp Wolfer
bfeabb7ba8 PICARD-2475: Fix "Lookup in browser" in search dialogs
If the search in the dialog contained a MBID, the "Lookup in browser" button would attempt to load this MBID as album / recording instead of opening the browser. Now force opening in browser.
2022-05-09 13:12:11 +02:00
Philipp Wolfer
abad06a7a5 PICARD-2473: EAC log disc lookup must be available on systems without CD drive
Make the lookup disc ID action always enabled. If there is not drive make the ripper log file lookup the default.
2022-05-08 16:06:43 +02:00
Philipp Wolfer
d7b80547a4 PICARD-2470: Allow utf-16 encoded EAC log files
EAC seems to save UTF-16 encoded files. There circulate TOC files in UTF-8 encoding, but mostly these are probably the result of copy and pasting the log.

Detect the encoding based on the BOM (which for UTF-16 should always be present).
2022-05-08 12:44:45 +02:00
Philipp Wolfer
288ca95ab7 PICARD-2474: Revert "PICARD-2420: Fix AcoustID submission getting enabled for files with fingerprint in tags"
This reverts commit 40877f6e22.
2022-05-08 12:42:48 +02:00
Philipp Wolfer
166aa6c5e4 PICARD-2465: Fixed potential recursion error when loading many releases
process_events_iter can cause unintended side effects. When loading many releases in parallel this can cause recursion depths errors.

This partially reverts changes done for PICARD-2454.
2022-05-04 17:05:22 +02:00
Philipp Wolfer
e6dafe020d Prepare release 2.8.0rc1 2022-05-03 08:57:43 +02:00
Philipp Wolfer
c56ab0dc74 Update constants
Adds medium format DataPlay and renames Music Card to Download Card
2022-05-03 08:46:53 +02:00
Philipp Wolfer
e720b14826 Update translations from transifex 2022-05-03 08:44:58 +02:00
Philipp Wolfer
5503257193 Update picard.pot 2022-05-01 15:38:26 +02:00
Philipp Wolfer
25d58f2660 Merge pull request #2101 from phw/PICARD-2415-other-versions-dialog
PICARD-2415: Show other release versions in search dialog
2022-05-01 14:35:22 +02:00
Philipp Wolfer
c40f10a04f Simplify album and track similarity search
Reuse existing search functonality, de-duplicate code.
2022-05-01 14:34:49 +02:00
Philipp Wolfer
9912df46e6 Dark theme color for search dialog row highlighting 2022-05-01 12:50:51 +02:00
Philipp Wolfer
358af73ca4 Sort list of release country codes 2022-05-01 12:09:37 +02:00
Philipp Wolfer
c8ccc290dc PICARD-2415: Make "Show other album versions" a top level action
This allows assigning a global shortcut and make it easily available.
2022-05-01 12:09:37 +02:00
Philipp Wolfer
2360c2db0e PICARD-2415: Allow searching and switching "other versions" in separate dialog
The submenu ist still displayed for quick selection, but a "Show more details..." menu option allows selecting a different version in a search dialog.
2022-05-01 12:09:36 +02:00
Philipp Wolfer
7149028eb5 Properly set advanced query initial checkbox state in search dialog 2022-04-29 08:39:42 +02:00
Philipp Wolfer
819e3229bf Merge pull request #2099 from phw/PICARD-2459-touch-cover-temp-files
PICARD-2459: Prevent macOS from removing temporary cover art files
2022-04-26 23:01:26 +02:00
Philipp Wolfer
7e3e8954cb periodictimer: Only register files if timer is active 2022-04-26 22:35:56 +02:00
Philipp Wolfer
fed641fa81 PICARD-2459: Prevent macOS from removing temporary cover art files
macOS cleans up temporary files if they haven't been accessed for three days. If Picard is left running for a longer period of time the files became missing.

Co-authored-by: Laurent Monin <github@norz.org>
2022-04-26 22:13:00 +02:00
Philipp Wolfer
54219bcd71 Fix TypeError when rendering cover art 2022-04-26 21:25:19 +02:00
Philipp Wolfer
950ce45de8 PICARD-2464: Fix rendering of cover art stack on HiDPI displays
Sizes where applied wrong when the pixel ratio > 1.0 was used, resulting in too small thumbnails inside the stack.

Solved by using logical pixel coordinates in the QPainter and setting the pixel ratio of the underlying QPixmap correctly.
2022-04-26 14:26:25 +02:00
Philipp Wolfer
aa480b8977 Merge pull request #2097 from phw/PICARD-2463-fix-coverart-per-screen-pixel-ratio
PICARD-2463: Fix coverart per screen pixel ratio
2022-04-26 12:09:23 +02:00
Philipp Wolfer
bc5c55a063 PICARD-2463: Preserve has_common_images on screen scale change 2022-04-26 11:30:42 +02:00
Philipp Wolfer
d6852cfa69 Move cover art stack render logic into separate method
Small refactoring to improve readability of the code
2022-04-26 11:30:42 +02:00
Philipp Wolfer
da88b05210 PICARD-2463: Handle screen scale changes for cover art
Re-render the cover art with adjusted resolution if the screen scaling changes when the main window gets moved to a different screen.
2022-04-26 08:20:51 +02:00
Philipp Wolfer
3c770d6c08 PICARD-2459: Handle cover art temp files missing
Do not crash if the temporary file for cover art is unexpectedly missing. Instead show a place holder pixmap.
2022-04-25 10:24:23 +02:00