Traceback (most recent call last):
File "/home/zas/src/picard/./picard/ui/mainwindow/__init__.py", line 300, in closeEvent
if not self.script_editor_dialog.unsaved_changes_confirmation():
AttributeError: 'ScriptEditorDialog' object has no attribute 'unsaved_changes_confirmation'. Did you mean: 'unsaved_changes_in_profile_confirmation'?
This issue was introduced in e253ef4956
- it was logging something like `Clustering <itertools.chain object at 0x7f318466ae60>`
- Now it will log something like:
`Clustering 21 files: (<FLACFile '1-01 Amsterdam, Amsterdam!.flac'>, <FLACFile '1-02 Them There Eyes.flac'>, <FLACFile "1-03 Sinner's Prayer.flac">, <FLACFile "1-04 Can't Let Go.flac">, <FLACFile '1-05 For My Friends.flac'>) and 16 more files...
`
- logged sequence of files is truncated to 5 files, but the number of files is shown in all cases
`update_active_action_for_widget()` is using `self._ignore_hover` flag to disable handling of hovered signal,
but this wasn't actually used, because, I think, of a typo in hovered signal handler which was testing `self._ignore_update` instead.
Also `_ignore_hover` wasn't initialized.
- rename source to colname
- add a property to ArtworkTable classes, named artwork_columns, listing ... artwork columns
- get rid of exception handling in _display_artwork_image_cell()
- properly escape content as the presence of html-like tags may cause it to switch to rich-text
- filenames displayed could contain such
- since it makes the tooltip rich-text, use strong/em to format text
- as a side effect, tooltip text will automatically wrap, it avoids display issues with very long paths
- it fixes a lot of issues regarding matching old to new cover art
- build rows first, display them row by row (before it was displaying column after column)
- code is much simpler and easier to follow
- keep orig / new naming scheme as it makes clear where the images are coming from
- display arrow in only one case: there are 2 images in new/orig and their types are matching
- images are sorted once at start (and this is taking care of front images first, matching comments, etc)
- before medium/comment A | medium/comment B could be matched to medium/comment B | medium/comment A, now the correct thing should happen
