Commit Graph

2844 Commits

Author SHA1 Message Date
Laurent Monin
ed43b1dac6 Merge pull request #290 from zas/build_scripts
Add build scripts fro win and osx, add patch_version command to setup.py
2014-04-15 13:38:59 +02:00
Laurent Monin
b3e8ec9db0 Add build scripts fro win and osx, add patch_version command to setup.py 2014-04-15 13:26:40 +02:00
Lukáš Lalinský
dc6ddcffd8 Merge pull request #289 from zas/build_version
Add new PICARD_BUILD_VERSION_STR
2014-04-15 11:58:20 +02:00
Laurent Monin
24ef7035e5 Add new PICARD_BUILD_VERSION_STR
It can be set by external script at build time.
PICARD_VERSION should not be modified.

See http://tickets.musicbrainz.org/browse/PICARD-592
2014-04-15 09:20:43 +02:00
Laurent Monin
1a98409bfd Merge pull request #263 from Sophist-UK/sophist_improve_unicode_to_ascii
Improve unicode to ascii ...
2014-04-14 13:20:26 +02:00
Sophist
45186e9850 Fix metadata to import from new location 2014-04-14 12:03:08 +01:00
Sophist
e406a554bc Address various comments by Philipp Wolfer ...
... based on actual knowledge of how characters are used in practice.

low quotation mark -> normal quotation mark rather than comma
oi should be gha -> gh rather than oi
ideographic punctuation, multiplication / division and middle dot are not punctuation
2014-04-14 11:57:35 +01:00
Sophist
110441f91e Address comments by 96187 ...
... whose local knowledge of how characters are actually used identified
more appropriate characters to map to.

soft hyphen -> nothing (since it is invisible)
multiplication -> x rather than * (visually closer)
remove duplicate oe
2014-04-14 11:57:34 +01:00
Sophist
0a34629945 Remove unnecessary lines (zas). 2014-04-14 11:57:32 +01:00
Sophist
323d12892c Improve unicode to ascii ...
for punctuation, normalization (merging similar looking characters into
the most common one), accents, and full conversion to ascii.

Functions and tests moved into separate files.

Although more comprehensive, the code should run faster because it
eliminates several loops (inc. a loop with two unicodedata references).

This is intended to form the basis of future PRs to:
a. Clean up (simplify) the file naming code
b. Provide script function(s) for cleaning individual tags / file name
parts
c. Add support for translation / transliteration plugins (which I think
make more sense than being included in Picard itself).
d. Support for converting Tags to ISO-8859-1 rather than ascii (since
that is what is supported by ID3 at least)
e. Possible additional options for allowing / preventing normalization,
possible reorganisation of options to centralise all encoding settings
onto one page rather than metadata, tags and file naming pages at
present (to be discussed).
2014-04-14 11:57:31 +01:00
Laurent Monin
445bf56bad Merge pull request #284 from phw/fix-cluster-artist-names
Fix clustering sometimes displaying "Various Artists"
2014-04-13 10:54:07 +02:00
Laurent Monin
084c13e1e8 Merge pull request #286 from zas/log_platform
Log platform infos in debug mode
2014-04-13 10:22:20 +02:00
Laurent Monin
9f56d48956 Add attributes po files 2014-04-13 10:21:15 +02:00
Laurent Monin
2623df5bb4 Merge pull request #254 from zas/cover_art_types
Use attributes.pot from musicbrainz server to generate up-to-date cover art types and medium formats lists
2014-04-13 10:16:32 +02:00
Laurent Monin
686b8b53eb Log platform infos in debug mode
It will help when logs are posted by users with bug reports.
2014-04-12 20:39:23 +02:00
Laurent Monin
a3dd66ffca Update pot file 2014-04-12 14:33:22 +02:00
Laurent Monin
1e70f73b8e Make strings easier to translate.
"%s cover art" (ie. "front cover art") is working in english, but not as well in other
languages, especially when type isn't even translated (for now).

Replaced with "cover art of type '%s'", which is slightly better when it comes to i18n.
2014-04-12 14:04:53 +02:00
Laurent Monin
c60c07b252 Merge pull request #265 from zas/load_plugins_contrib
PICARD-575: load plugins from contrib/ too when run from source directory
2014-04-11 22:37:06 +02:00
Laurent Monin
1e596493f3 Merge pull request #283 from phw/fix-loading-mp3-without-tags
Fix loading MP3s without tags.
2014-04-11 22:32:52 +02:00
Philipp Wolfer
ae5fe08e9f Fix clustering sometimes displaying "Various Artists"
This fix is twofold:
1. Fixes the bug where the clustering does not select an artist name when there are some artist names appearing only once and those are at the end of the tracklist.
2. Use album artist tag, if present in the files.

Having this patch clusters will only have "Various Artists" set when there is either no artist set or all tracks are by different artists.
2014-04-11 21:39:55 +02:00
Philipp Wolfer
925c518008 Fix loading MP3s without tags.
This fixes setting the ID3 version when there are no tags at all in a MP3 file.
2014-04-11 21:39:00 +02:00
Wieland Hoffmann
66a2369d83 Only update tagger.nats if it's not None
If it's None, there's nothing to update.
2014-04-11 15:32:05 +02:00
Wieland Hoffmann
33e67fa2d6 Merge branch 'plugin-addtracktomb' of https://github.com/Freso/picard 2014-04-11 14:12:53 +02:00
Laurent Monin
ec12c71dbd Merge pull request #282 from Sophist-UK/sophist_debug_log_album_already_loaded
Provide debug message if Album / NAT already loaded
2014-04-11 13:40:07 +02:00
Sophist
56ddac250d Provide debug message if already loaded
See http://forums.musicbrainz.org/viewtopic.php?id=4916 for example of
need.
2014-04-11 12:14:22 +01:00
Wieland Hoffmann
a1bf54bfdf Remove an unused import of defaultdict 2014-04-11 10:50:24 +02:00
Wieland Hoffmann
cce70806c7 Move the socket import to the not-win32 code path
Otherwise, we'd have to ship the socket module in the windows installer,
but it's not used on windows.
2014-04-11 10:49:33 +02:00
Michael Wiencek
e2c0e06ec8 s/coverart/cover art/ 2014-04-10 15:22:18 -05:00
Laurent Monin
cf52994989 PEP8 fixes. 2014-04-10 10:57:26 +02:00
Laurent Monin
68d424c250 Make Cover Art Type selector use available space 2014-04-10 10:34:25 +02:00
Laurent Monin
c2dc4df511 Update NEWS.txt 2014-04-10 10:21:36 +02:00
Laurent Monin
a2a84ac8e6 Convert release_type_scores option to ListOption
We had a space-separated list of name,value tuples ("Album 0.5 Other 0.4"),
and two helper functions to load and save data in the correct format
(`load_release_type_scores` and `save_release_type_scores`).

Since option is converted to recently-introduced ListOption, data is now saved
as a list of tuples, eventually converted to dict when needed.
It simplifies code, and also prevents an issue if it comes we have a release group type
with a space in its name.

An upgrade hook was added to handle this change on Picard upgrade.
2014-04-10 10:21:30 +02:00
Laurent Monin
91cd68022e Build release type score sliders UI dynamically. 2014-04-10 10:20:53 +02:00
Laurent Monin
e59fabda3f Build RELEASE_PRIMARY_GROUPS and RELEASE_SECONDARY_GROUPS from MB_ATTRIBUTES 2014-04-10 10:20:53 +02:00
Laurent Monin
175ed700b5 Ensure proper translation of cover art types 2014-04-10 10:20:53 +02:00
Laurent Monin
a53164a5ee Build RELEASE_FORMATS and CAA_TYPES from MB_ATTRIBUTES 2014-04-10 10:20:52 +02:00
Laurent Monin
490e24d243 Add ugettext_attr() function needed to translate attributes
Since contexts are used in attributes.pot, and python gettext do not yet
support contexts, a minor hack is used to make it work, this workaround
is used in django and babel, see ugettext_ctxt().
2014-04-10 10:20:52 +02:00
Laurent Monin
08fdb55414 Update picard/attributes.py and picard/countries.py
New setup.py update_constants command was used.
2014-04-10 10:20:52 +02:00
Laurent Monin
8ac7014dfe Add update_constants command to setup.py
It retrieves and parses attributes.pot and countries.pot files
from transifex to extract various constants needed in Picard.
It helps to keep those in sync with MusicBrainz website.

It then generates:
- picard/attributes.py containing cover art types, medium formats, and release group types
- picard/countries.py containing countries

`update_constants` command replaces `update_countries`
2014-04-10 10:20:52 +02:00
Laurent Monin
1b90304f16 Update pot file 2014-04-10 10:18:05 +02:00
Laurent Monin
1f4689d4fa Merge pull request #238 from Sophist-UK/sophist_add_open_collection_in_browser
Various UI improvements
2014-04-10 09:35:10 +02:00
Sophist
044d4482db Fix makeqrc same results Windows and Mac 2014-04-09 12:05:26 +01:00
Frederik "Freso" S. Olesen
8bca1ecfbb addrelease.py: Use approximated "~length" for Recordings.
Recordings don't support sub-second time precision, so the
track.metadata.length used for the two Add...AsRelease classes will
cause an error on /recording/create's "length" field.
track.metadata["~length"] contains the time converted to mm:ss format
and will not cause the error on /recording/create, so this commit
changes AddFileAsRecording to use that.
2014-04-08 21:55:12 +02:00
Sophist
244db6139d Add Play File plus icons ... 2014-04-08 18:33:31 +01:00
Sophist
c898d7d888 Make Lookup CD / Browser consistent, ...
... and fix if statement.

(zas comments).
2014-04-08 18:33:29 +01:00
Sophist
4347cc2cba Address various zas comments 2014-04-08 18:33:28 +01:00
Sophist
3b4b71d1ca Revert new status tips / tooltips ...
... and tweak browser integration tooltip.
2014-04-08 18:33:27 +01:00
Sophist
e6b2a20488 Add comment for zas 2014-04-08 18:33:26 +01:00
Sophist
d127edad8c And some more Bitmap comments...
which didn't show on the GitHub comments page.
2014-04-08 18:33:25 +01:00
Sophist
1a57e15f7a Fix tab order which I failed to adjust. 2014-04-08 18:33:23 +01:00