Commit Graph

7535 Commits

Author SHA1 Message Date
Wieland Hoffmann
392b03f21d Merge branch 'master' of github.com:musicbrainz/picard into mb-master 2013-10-01 15:03:13 +02:00
Wieland Hoffmann
36b452a0a1 Merge branch 'sophist_fix_id3v23_date_yyyy-mm' of https://github.com/Sophist-UK/picard into mb-master 2013-10-01 15:00:30 +02:00
Frederik "Freso" S. Olesen
64078b748d Make AcoustID use Recording IDs instead of Track IDs. (PICARD-526) 2013-09-29 12:14:59 +02:00
Michael Wiencek
dd9d10cd5f Merge branch 'sophist_fix_plugin_install' of git://github.com/Sophist-UK/picard into Sophist-UK-sophist_fix_plugin_install
Conflicts:
	NEWS.txt
2013-09-24 16:30:30 -05:00
Michael Wiencek
cceb3a01c8 Merge branch 'sophist_add_recordingtitle' of git://github.com/Sophist-UK/picard into Sophist-UK-sophist_add_recordingtitle
Conflicts:
	NEWS.txt
2013-09-24 16:16:57 -05:00
Wieland Hoffmann
df7aa78e14 Add releasetrackid to NEWS.txt 2013-09-24 19:42:21 +02:00
Wieland Hoffmann
0becd0590e mbxml: move a comment to the code it refers to 2013-09-24 19:37:15 +02:00
Sophist
e05c580fdb Add News. 2013-09-23 20:41:00 +01:00
Sophist
e38626dc9f Add recordingtitle as per PICARD-515
This fix adds a %_recordingtitle% script variable for use in renaming as
per PICARD-515.
2013-09-23 20:40:59 +01:00
Sophist
08252d8017 Add News. 2013-09-23 15:42:24 +01:00
Sophist
fb9aefbc95 Add explanatory comment 2013-09-23 15:26:02 +01:00
Sophist
d2689dc8bd Fix error when installing over existing plugins
As reported in PICARD-444, the following error is received when
installing over an existing plugin:

Traceback (most recent call last):
File ".\picard\ui\options\plugins.py", line 134, in open_plugins
self.install_plugin(path)
File ".\picard\ui\options\plugins.py", line 148, in install_plugin
self.tagger.pluginmanager.install_plugin(path, dest)
File ".\picard\plugin.py", line 198, in install_plugin
same_file = os.path.samefile(path, dest) if dest_exists else False
AttributeError: 'module' object has no attribute 'samefile'
2013-09-23 15:15:54 +01:00
Sophist
c929f1c793 Fix plugin install code
Fix following errors:

1. On plugin install:
Traceback (most recent call last):
File ".\picard\ui\options\plugins.py", line 133, in open_plugins
self.install_plugin(path)
File ".\picard\ui\options\plugins.py", line 138, in install_plugin
dest = os.path.join(self.tagger.user_plugin_dir, file)
AttributeError: 'Tagger' object has no attribute 'user_plugin_dir'

2. On Open Plugin Folder:
Traceback (most recent call last):
File ".\picard\ui\options\plugins.py", line 151, in open_plugin_dir
QtGui.QDesktopServices.openUrl(QtCore.QUrl(self.loader %
self.tagger.user_plugin_dir, QtCore.QUrl.TolerantMode))
AttributeError: 'Tagger' object has no attribute 'user_plugin_dir'.

Code missed from commit 7c4fdf765c on
2013-06-08.
2013-09-23 14:49:54 +01:00
Calvin Walton
769748c276 Fix the track test to include track mbid, change internal recording id name 2013-09-22 14:24:24 -04:00
Calvin Walton
04c30355e2 Rename internal trackid to recordingid, add a new tag for trackids. 2013-09-22 14:15:21 -04:00
Michael Wiencek
f9953186cc Merge pull request #157 from kepstin/desktop-fix
Add 'Audio' to the categories in the .desktop file
2013-09-04 09:59:50 -07:00
Calvin Walton
4553b5824f Add 'Audio' to the categories in the .desktop file
As per
http://blogs.gnome.org/hughsie/2013/09/03/broken-desktop-files/
it should have both 'AudioVideo' and one or both of 'Audio' or 'Video'
in order to be categorized correctly.
2013-09-03 14:11:56 +00:00
Michael Wiencek
5d0ea9ce99 Merge pull request #156 from zas/pep8_plugins
Improve conformance to PEP8, tidy up.
2013-09-02 15:40:34 -07:00
Laurent Monin
8194168f5d Unify comment style 2013-08-18 20:05:08 +02:00
Laurent Monin
c272099bd9 Improve conformance to PEP8, tidy up. 2013-08-15 15:01:41 +02:00
Sophist
306b8c7fc8 Fix stupid coding error in mimeo comment response. 2013-08-14 19:14:29 +01:00
Wieland Hoffmann
de8c27134f Adjust the replaygain plugin to the changes in threading 2013-08-14 18:22:51 +02:00
Sophist
1a5e5433a7 Fix issue with date format yyyy-mm
MB sometimes gives dates in form yyyy-mm. Mutagen cannot save id3v23
dates in this format and truncates them to yyyy. Then they don't match
when the file is reloaded.

This fix detects New metadata dates in this format and truncates them.
2013-08-13 12:09:59 +01:00
Michael Wiencek
e772e9093e Merge pull request #151 from zas/tracknum
Use a smarter method to extract track number from filename.
2013-08-12 19:55:24 -07:00
Laurent Monin
54ef078dc0 Move constant regexps outside the tracknum_from_filename() function 2013-08-12 16:52:03 +02:00
Michael Wiencek
cf91b1a285 Merge pull request #154 from zas/browser_options
Browser options
2013-08-08 13:13:07 -07:00
Laurent Monin
00c09b389f Remove now unused FileLookup._encode(). 2013-08-06 19:09:57 +02:00
Laurent Monin
ff0bd54153 Add a real life test for track number case extraction 2013-08-06 14:48:49 +02:00
Laurent Monin
a6c8b1b1cd Move Browser Integration options to Advanced > Network option page 2013-08-05 22:02:18 +02:00
Laurent Monin
7ec5bb25de Rename "Web Proxy" option page to "Network"
Settings for web proxy are still there, but we'll add browser integration
options to this option page too.
2013-08-05 21:51:42 +02:00
Laurent Monin
c165fd862f Add options to control browser integration (enabled/disabled and listening port) 2013-08-05 15:41:25 +02:00
Ionuț Ciocîrlan
4c7e31cc6b Merge remote-tracking branch 'upstream/master'
Conflicts:
	picard/file.py
2013-08-05 13:05:14 +03:00
Laurent Monin
77cdedbd9f Use an url builder to simplify code.
_url() will ensure correct query building, encoding, query parameters are passed
as a dictionary
2013-08-05 12:05:10 +02:00
Laurent Monin
2ec0631217 Use a smarter method to extract track number from filename.
When file has no metadata field indicating the track number, Picard
is trying to guess it from filename, but the simple regex wasn't very efficient.

tracknum_from_filename() does a much better job.
A test case was added.
2013-08-05 00:40:11 +02:00
Michael Wiencek
fcc0be4ea9 Merge pull request #149 from zas/PEP8_shoot_again
PEP8 conformance fixes.
2013-08-04 15:11:21 -07:00
Michael Wiencek
12850d038b Merge pull request #152 from zas/replace_words
Remove unused dict since ac9989fd
2013-08-04 10:10:05 -07:00
Laurent Monin
03254d1f12 Remove unused dict since ac9989fd 2013-08-04 14:00:36 +02:00
Laurent Monin
3cd397b9fa PEP8 conformance fixes. 2013-08-04 10:19:05 +02:00
Michael Wiencek
9940bcef88 Merge pull request #150 from sebastinas/except-shadows-builtin
Correctly catch IOError
2013-08-03 11:50:48 -07:00
Sebastian Ramacher
305b694225 Correctly catch IOError
except OSError, IOError does not catch IOError but will overwrite IOError with
catched exception. See [1] for detauls.

[1] http://docs.python.org/2/whatsnew/2.6.html#pep-3110-exception-handling-changes

Signed-off-by: Sebastian Ramacher <sramacher@debian.org>
2013-08-03 20:47:00 +02:00
Michael Wiencek
a61887392c Merge pull request #147 from zas/statushistory
Store and display status messages in a window similar to the Log window
2013-08-01 11:27:37 -07:00
Laurent Monin
6a3fd98530 formatted_log_line(): drop useless append parameter 2013-07-28 01:18:08 +02:00
Wieland Hoffmann
84354dcc68 Remove a superfluous import of picard.util.queue
It has been removed, so this import made picard unstartable on clean
checkout (old ones most likely has a .pyc file of the queue module lying
around).
2013-07-27 10:14:54 +02:00
Laurent Monin
5281349e24 Do not display level prefix for history (always LOG_INFO) 2013-07-24 22:17:47 +02:00
Laurent Monin
a5f533e0cb Use formatted_log_line() in _stderr_receiver() 2013-07-24 22:04:26 +02:00
Laurent Monin
c395ca4978 Use log.formatted_log_line() in LogViewCommon 2013-07-24 22:04:08 +02:00
Laurent Monin
44952bb3f9 Add a function to format a log line in human-readable form 2013-07-24 22:02:49 +02:00
Laurent Monin
9f2abe1c02 Add a window for status history display.
Launch from Help menu for now
2013-07-24 22:02:49 +02:00
Laurent Monin
d381e810a0 Add a logger for status history 2013-07-24 22:02:49 +02:00
Laurent Monin
8fa19acf97 show_log(): minor tidy up 2013-07-24 21:43:38 +02:00