Commit Graph

7535 Commits

Author SHA1 Message Date
Laurent Monin
86ed552b21 Make modified releases a bit more obvious using a specific icon. 2013-07-02 23:38:31 +02:00
Laurent Monin
258e9c2084 Use info dialog to display per-album error log.
When an error occurs during loading of a release, it will be visible
in info dialog for this release (which was unused).

New icon was added to mark visually releases with errors, and scrollbars
will appear in info dialog if needed.
2013-07-02 23:38:31 +02:00
Michael Wiencek
694b1d6c58 Merge pull request #140 from zas/pep8
PEP8 compliance fixes
2013-07-02 14:17:34 -07:00
Laurent Monin
8d40e6700d pep8 fixes 2013-07-02 23:01:13 +02:00
Michael Wiencek
cd656964f1 Merge pull request #139 from zas/deprecated_unittest_aliases
Replace deprecated unittest aliases
2013-07-02 09:39:01 -07:00
Laurent Monin
1265d5fd1c PEP8 compliance fixes 2013-07-02 10:19:34 +02:00
Laurent Monin
97f00b2d29 Handle configuration file versions.
version_info was renamed PICARD_VERSION
version_string was renamed PICARD_VERSION_STR
short version string is stored in PICARD_VERSION_STR_SHORT (for display)

Hooks can be created to handle upgrades (ie. options renaming), see config.register_upgrade_hook() and config.run_upgrade_hooks()
2013-07-02 01:45:25 +02:00
Laurent Monin
329ed8cedb Deprecated failUnlessAlmostEqual() -> assertAlmostEqual()
http://docs.python.org/2/library/unittest.html#deprecated-aliases
2013-07-01 13:34:53 +02:00
Laurent Monin
60ed243470 Deprecated failUnlessRaises() -> assertRaises()
http://docs.python.org/2/library/unittest.html#deprecated-aliases
2013-07-01 13:33:42 +02:00
Laurent Monin
6062fe404e Deprecated failIfEqual() -> assertNotEqual()
http://docs.python.org/2/library/unittest.html#deprecated-aliases
2013-07-01 13:31:41 +02:00
Laurent Monin
403bafbbaa Deprecated failUnlessEqual() -> assertEqual()
http://docs.python.org/2/library/unittest.html#deprecated-aliases
2013-07-01 13:29:57 +02:00
Michael Wiencek
fe17c2cb3c Copy value list in Metadata.update 2013-06-30 17:56:26 -05:00
Michael Wiencek
fd30cb62ee functools.partial is 2.5+ 2013-06-30 16:15:27 -05:00
Michael Wiencek
b1980e6ac8 Merge pull request #126 from mwiencek/throttle-gui
Add @throttle decorator to reduce the number of GUI updates
2013-06-30 14:02:46 -07:00
Michael Wiencek
90c43c72e1 Add @throttle decorator to reduce the number of GUI updates 2013-06-30 16:00:22 -05:00
Michael Wiencek
5568dc7c3e Merge pull request #134 from zas/status_icons
Display icons with tooltip instead of text for counters in status bar
2013-06-30 13:39:37 -07:00
Laurent Monin
1802208d69 Use a green down arrow as download icon instead of globe.
In 16x16 globe is too complex, arrow is much more legible.
2013-06-30 22:01:21 +02:00
Laurent Monin
a545c10cad Merge remote-tracking branch 'upstream/master' into status_icons 2013-06-30 21:50:39 +02:00
Laurent Monin
748502419a Remove incorrect author from header. 2013-06-30 21:49:26 +02:00
Michael Wiencek
befd8d8f57 Merge pull request #138 from zas/parse_amazon_url
Create a function to parse amazon urls and reduce code redundancy.
2013-06-30 10:45:27 -07:00
Michael Wiencek
910725ed70 Merge pull request #136 from zas/resources_tools
Improve resources tools
2013-06-30 10:39:52 -07:00
Laurent Monin
f892444998 Create a function to parse amazon urls and reduce code redundancy.
A test for amazon url parsing was added.
2013-06-30 17:25:15 +02:00
Laurent Monin
c8af60e21a Use unix eol in generated ressource file. 2013-06-30 05:04:47 +02:00
Laurent Monin
0661491f37 Use len() instead of a counter. 2013-06-30 05:02:45 +02:00
Laurent Monin
746fa31286 Use resources makeqrc and compile code, reducing code redundancy.
An empty __init__.py file was added so functions can be imported.
2013-06-28 12:39:53 +02:00
Laurent Monin
26f595a068 Mark compile.py and makeqrc.py as executables, they have python bang path. 2013-06-28 12:39:42 +02:00
Laurent Monin
b974a9cf63 Make compile.py runnable from anywhere and importable. 2013-06-28 12:39:30 +02:00
Laurent Monin
5f5afa7d02 Add script to generate picard.qrc from png images in images directory 2013-06-28 12:39:16 +02:00
Laurent Monin
22d99966dc Move source images (.psd, .svg) from images to img-src directory 2013-06-28 12:39:02 +02:00
Michael Wiencek
d729e205cf Merge pull request #135 from zas/unicode_str_error
Fix a TypeError, str vs unicode.
2013-06-27 12:29:13 -07:00
Laurent Monin
d2baf4449d Fix a TypeError, str vs unicode.
E: 139836956702464 21:25:09 Traceback (most recent call last):
  File "./picard/album.py", line 133, in _parse_release
    run_album_metadata_processors(self, m, release_node)
  File "./picard/metadata.py", line 334, in run_album_metadata_processors
    processor(tagger, metadata, release)
  File "./picard/coverart.py", line 178, in coverart
    config.setting["caa_image_types"].split())
TypeError: descriptor 'lower' requires a 'unicode' object but received a 'str'
2013-06-27 21:26:11 +02:00
Laurent Monin
4aa4cd411e Reduce spaces between counters. 2013-06-27 19:18:59 +02:00
Laurent Monin
559ec4e74b Include active requests in the pending requests count.
Counter was 0 if request queue was empty but Picard was still waiting for replies,
with this change, counter is set to 0 only if no active request left.
2013-06-27 18:17:42 +02:00
Laurent Monin
78df904c77 Use icons for counters in status bar 2013-06-27 18:02:55 +02:00
Michael Wiencek
d8b1b79d02 Add missing import 2013-06-23 12:03:32 -05:00
Michael Wiencek
9446b03d2e Use config module in ID3Metadata 2013-06-23 11:49:23 -05:00
Michael Wiencek
1d61c2ebd3 Merge branch 'Sophist-UK-sophist_id3v23_matching_v2'
Conflicts:
	picard/file.py
	picard/formats/id3.py
	picard/ui/metadatabox.py
	picard/ui/options/tags.py
2013-06-23 11:46:25 -05:00
Michael Wiencek
c54205e2c8 Merge pull request #132 from zas/amazon_regex_const
Move duplicated amazon asin regex to const.py
2013-06-21 15:56:51 -07:00
Laurent Monin
46d47f6edc Move duplicated amazon asin regex to const.py 2013-06-21 13:30:03 +02:00
Michael Wiencek
b520e33023 Merge pull request #130 from zas/bytes2human_nofrtest
Remove fr_FR locale test, too much a requirement.
2013-06-19 12:44:48 -07:00
Laurent Monin
4fc84a428b Remove (now) useless data test file. 2013-06-19 19:27:10 +02:00
Laurent Monin
fdbed3f6c1 Remove fr_FR locale test, too much a requirement. 2013-06-18 12:24:09 +02:00
Ionuț Ciocîrlan
e68dc99bf6 Merge remote-tracking branch 'upstream/master' 2013-06-17 21:50:47 +03:00
Ionuț Ciocîrlan
fe8f6c2176 Characters counted in UTF-16 code points where appropriate.
NFD handled under OS X.
Windows bugfix when the relative directory path is short enough.
2013-06-17 21:42:10 +03:00
Sophist
da1c2239b3 Fix review comments from luks 2013-06-17 09:15:48 +01:00
Sophist
26b310d04b Minor white-space tweaks 2013-06-17 07:48:45 +01:00
Lukáš Lalinský
b3f2e99130 Merge remote-tracking branch 'zas/info_dialog2'
Conflicts:
	picard/tagger.py
2013-06-17 08:20:42 +02:00
Michael Wiencek
dfc790226d Remove some obsolete code
Python 2.5 is no longer supported.
2013-06-16 22:01:32 -05:00
Sophist
7a7c255c6e Fix white-space issues as pep8 2013-06-16 12:39:13 +01:00
Sophist
69c73f2527 Handle id3v23 date / original date in yyyy only
For id3 files where picard is set to write id3v23 tags, truncate dates
provided by MB to yyyy (from yyyy-mm-dd).
2013-06-16 12:09:08 +01:00