Laurent Monin
885006a73d
Move log and logview code to classes, to ease re-use.
2013-07-24 21:43:38 +02:00
Laurent Monin
678d472d6f
_message(): do not convert unicode strings
...
Receivers have to take care of conversion instead, if needed.
2013-07-24 21:39:31 +02:00
Laurent Monin
06ac040bf9
_stderr_receiver(): improve reporting of UnicodeDecodeError
2013-07-24 21:39:31 +02:00
Michael Wiencek
ca12a56825
Merge pull request #146 from mwiencek/new-threadpool
...
Use QThreadPool for threading
2013-07-24 10:51:50 -07:00
Michael Wiencek
14c2db23f7
Merge branch 'master' into new-threadpool
...
Conflicts:
picard/ui/mainwindow.py
2013-07-23 13:24:44 -05:00
Michael Wiencek
135648d862
Use separate thread pool for file saving
...
With a thread count of 1, to avoid race conditions in File._save_and_rename.
2013-07-23 13:23:05 -05:00
Michael Wiencek
cc5c51a170
Merge pull request #148 from ianmcorvidae/patch-1
...
Add '/' to _escape_lucune_query in webservice.py
2013-07-16 20:09:12 -07:00
Ian McEwen
3e266c1eb1
Add '/' to _escape_lucune_query in webservice.py
...
Due to Lucene 4 updates, this is necessary.
2013-07-15 07:18:50 -07:00
Wieland Hoffmann
fc7239de2c
_save_images: continue after deciding a file doesn't need to be saved
...
The previous code was `return`ing from the function, so images after the
first already existing one were not even considered for saving.
2013-07-09 14:21:44 +02:00
Wieland Hoffmann
0c15a5d284
Regenerate picard.pot
2013-07-08 19:10:26 +02:00
Wieland Hoffmann
9dc6f16422
Don't throw an AttributeError if no discid module is available
...
The cd lookup button was enabled even if no discid module was available,
don't do that.
Additionally, display information about the missing discid module in the
About window.
This fixes PICARD-510
2013-07-08 19:05:37 +02:00
Ionuț Ciocîrlan
5a4de95f85
Messing with settings:
...
Revert `options_renaming` UI files back to upstream/master (gets rid of `move_files_ancestor`).
Stick to `windows_compatibility` setting name, and handle upgrade.
Rename `move_files_ancestor` setting to `windows_compatibility_drive_root`.
2013-07-08 14:33:24 +03:00
Ionuț Ciocîrlan
aaab0dae48
moved filenaming stuff to its own module
2013-07-06 11:38:12 +03:00
Ionuț Ciocîrlan
b07e7f3e4d
Merge remote-tracking branch 'upstream/master'
...
Conflicts:
picard/util/__init__.py
test/test_utils.py
2013-07-06 10:21:00 +03:00
Michael Wiencek
e40e1f393b
Use QThreadPool for threading
2013-07-04 20:45:06 -05:00
Michael Wiencek
72dce65f09
Merge pull request #143 from zas/logview
...
Improve logging code and display
2013-07-04 12:21:07 -07:00
Laurent Monin
f10892ca72
Drop currentThreadId in stderr output
2013-07-04 21:00:23 +02:00
Laurent Monin
2fd2487373
_stderr_receiver(): include ':' in format string instead of each dict entry
2013-07-04 21:00:23 +02:00
Laurent Monin
bc0f7d74ab
Let the receiver convert time to string.
2013-07-04 21:00:23 +02:00
Laurent Monin
c31ffe12f1
logview: code cleanup
2013-07-04 21:00:23 +02:00
Laurent Monin
6e9078e188
logview: enable minimize/maximize for log dialog windows
2013-07-04 21:00:23 +02:00
Laurent Monin
f380be442e
_entries -> entries as it is used outside log module
2013-07-04 21:00:18 +02:00
Laurent Monin
be7965dd6f
log: use bitwise operators for log levels matching
2013-07-04 20:59:07 +02:00
Laurent Monin
ea2a95eec4
log, logview: use levels instead of prefixes and colorize log view output
2013-07-04 20:57:53 +02:00
Laurent Monin
b55976002d
logview: limit number of lines stored in memory to 50000
2013-07-04 20:55:34 +02:00
Laurent Monin
3608612bd6
logview: remove log receiver when dialog is closed
2013-07-04 20:54:04 +02:00
Michael Wiencek
b06d6b88a2
Merge pull request #144 from zas/config_upgrade_fix1
...
Fix up format error
2013-07-03 18:13:48 -07:00
Laurent Monin
5c6c7c7e3d
Fix up format error introduced c6494fa18f
2013-07-04 00:49:29 +02:00
Wieland Hoffmann
93bb43ec6e
File._rename: Return early if the new filename is the same as the old one
...
This is mostly for readability.
2013-07-03 17:48:35 +02:00
Wieland Hoffmann
8ba96e4851
Unbreak moving WavPack correction files
...
The `settings` argument to `File._rename` has been removed in 7c4fdf76
2013-07-03 17:48:35 +02:00
Michael Wiencek
8df21aaae2
Merge pull request #142 from zas/pep8_tests
...
tests: PEP8 fixes
2013-07-02 18:40:48 -07:00
Laurent Monin
7dd311697f
tests: PEP8 fixes
2013-07-03 03:37:24 +02:00
Michael Wiencek
7325a73507
Update INSTALL.txt
2013-07-02 19:31:05 -05:00
Michael Wiencek
157df15443
Don't crash if python-discid is missing
2013-07-02 19:30:44 -05:00
Michael Wiencek
28b1a0a05b
Use uniqify in get_files_from_objects
2013-07-02 19:03:18 -05:00
Michael Wiencek
b8234bfdf4
Merge pull request #129 from zas/discid
...
Use python-discid instead of libdiscid
2013-07-02 16:59:39 -07:00
Michael Wiencek
6bbf7b75e5
Merge branch 'master' of github.com:musicbrainz/picard
2013-07-02 18:41:49 -05:00
Michael Wiencek
c6494fa18f
Move the VA file naming upgrade to the new hook system
2013-07-02 18:40:40 -05:00
Michael Wiencek
5182c46f67
Merge pull request #141 from zas/remove_parserfilename
...
Unused file, only one function never called, test part broken since 2006
2013-07-02 16:31:44 -07:00
Laurent Monin
b9477ed92b
Unused file, only one function never called, test part broken since 2006
2013-07-03 01:28:17 +02:00
Laurent Monin
07424f2b75
Fix duplicate CD drives in the drop-down: "D:" and "D:\", on Windows
2013-07-03 00:44:32 +02:00
Sebastian Ramacher
529cc4e495
Also try to use python-libdiscid
...
python-libdiscid is another libdiscid binding that also provides a python-discid
compatible interface in libdiscid.compat.discid.
Signed-off-by: Sebastian Ramacher <sebastian+dev@ramacher.at >
2013-07-03 00:44:32 +02:00
Laurent Monin
2fae933a6c
Ensure each drive is present at most once in the list.
...
When Picard legacy method to list drives returns one that is already
set by python-discid (which is very likely on Windows systems).
2013-07-03 00:44:32 +02:00
Laurent Monin
b4378041e7
Add uniqify() helper function to uniqify a list
...
From http://www.peterbe.com/plog/uniqifiers-benchmark
2013-07-03 00:44:32 +02:00
Laurent Monin
b968b44152
Use discid/libdiscid drive auto detection, especially on first start
...
It will add default drive as returned by libdiscid to the list of known drives
Ie. on linux, list is : /dev/cdrom, /dev/sr0, /dev/sr1 (default link + 2 sata cd readers)
On first start it will populate the list with default drive provided by libdiscid,
which means Picard is now able to scan CD without going to Options (to set
cd reader) first, which was not the case before.
2013-07-03 00:44:32 +02:00
Laurent Monin
f742a46846
Use python-discid instead of libdiscid.
...
Python-discid (http://python-discid.readthedocs.org ) is a Python binding of libdiscid.
It resolves http://tickets.musicbrainz.org/browse/PICARD-503
2013-07-03 00:44:32 +02:00
Michael Wiencek
9e8d494948
Merge pull request #127 from zas/album_error
...
Improve feedback regarding album status
2013-07-02 15:32:44 -07:00
Michael Wiencek
b3fcb04f9c
Merge pull request #131 from zas/update_config_2
...
Handle configuration file versions
2013-07-02 15:06:58 -07:00
Laurent Monin
ebceb8aa05
Switch tab title to Errors when needed.
2013-07-02 23:38:31 +02:00
Laurent Monin
31a928966a
Display cover art errors associated with album if any
2013-07-02 23:38:31 +02:00
