Commit Graph

7535 Commits

Author SHA1 Message Date
Laurent Monin
0da4ab5d74 Tidy up script tests
Remove useless whitespaces
Fix typo in comment
test_optional_kwonly_parameters(): self is unused -> static method
Use raw string notation
2020-02-20 20:53:02 +01:00
Philipp Wolfer
265ed0775e PICARD-1755: Specify available languages for Windows Store.
For now limit this to the languages for which there is also a localized store page (which is based on completion of translating the appstream data).
2020-02-20 18:22:16 +00:00
Philipp Wolfer
3ffa21eb08 PICARD-1754: Removed QKeySequence.Delete shortcut for remove action
This reverts 84d8341. QKeySequence.Delete is still used for item removal on the itemview and metadatabox panes (see MainWindow.keyPressEvent). But if this action is registered globally item removal interfers with removing elements from MetadataBox.
2020-02-20 15:17:41 +00:00
Philipp Wolfer
12f1452c96 PICARD-1750: Add AcoustID fingerprint from tags to AcoustIDManager
If a file has an existing AcoustID fingerprint in its tags and ignore_existing_acoustid_fingerprints is not set, then use this fingerprint to properly initialize the AcoustIDManager. This makes the existing fingerprint available for submission.

Previously such a file would not have its fingerprint used even after a Scan.
2020-02-20 07:29:51 +00:00
Philipp Wolfer
7e350da299 Refactor File to handle acoustid_fingerprint
acoustid_fingerprint is now a normal attribute of File and always available. Adding and removing the file to and from the AcoustIDManager is now completely handled in File.
2020-02-20 07:29:51 +00:00
Philipp Wolfer
800f61e6b6 PICARD-1752: Use the first matching preferred release country
For releases with multiple release countries use the first matching preferred release country for %releasecountry%.
2020-02-19 21:55:23 +00:00
Philipp Wolfer
7539d8dc23 PICARD-1751: Provide a ~releasecountries variable 2020-02-19 21:55:23 +00:00
Laurent Monin
fd25dc987d PICARD-1748: limit number of countries displayed to 10 2020-02-19 20:11:58 +00:00
Philipp Wolfer
04a771a2f9 macOS: Set LSMinimumSystemVersion based on MACOSX_DEPLOYMENT_TARGET 2020-02-17 23:56:41 +01:00
Philipp Wolfer
b029eb8374 PICARD-1745: Set MACOSX_DEPLOYMENT_TARGET to 10.12
Attempt to build a libdiscid compatible with macOS 10.12
2020-02-17 23:55:11 +01:00
Philipp Wolfer
3de8ee49a1 Release 2.3 2020-02-17 21:04:51 +01:00
Philipp Wolfer
ea99e4d294 Updated translations 2020-02-17 20:51:18 +01:00
Philipp Wolfer
a33133b13e PICARD-1744: Fixed crash on invalid ignore_regex 2020-02-16 18:58:21 +01:00
Philipp Wolfer
4027eeafff Added German with Swiss ortography
de_CH does not seem to be supported on Transifex, but the differences to German (Germany) are small. The de_CH.po only contains the strings with differences, gettext will automatically fallback to "de" for the rest.
2020-02-15 14:23:10 +01:00
Bob Swift
6683dcf891 Remove unnecessary 'try' block from $slice function 2020-02-14 08:16:02 +01:00
Laurent Monin
f3ca11c161 Merge pull request #1471 from zas/translate_nsh_french
French translation for installer (.nsh)
2020-02-13 16:42:31 +01:00
Laurent Monin
4b2bfc2b5a Minor French installer translation fixes 2020-02-12 22:33:15 +01:00
Laurent Monin
2aafa0f5e8 Enable French language for installer 2020-02-12 18:21:16 +01:00
Laurent Monin
cd295cf8e2 Merci de -> veuillez
Suggested by trebmuh
2020-02-12 17:29:43 +01:00
Laurent Monin
94b1628533 French translation for installer (.nsh) 2020-02-12 16:28:45 +01:00
Philipp Wolfer
a9b16c2578 PICARD-1740: Store originalfilename to ASF as WM/OriginalFilename
See also:
- http://msdn.microsoft.com/en-us/library/ms867702.aspx
- https://help.mp3tag.de/main_tags.html
2020-02-11 23:46:55 +01:00
Philipp Wolfer
c018f076ea PICARD-1739: Use new Version class for version comparison in update check
Fixes update check not properly comparing alpha, beta and rc releases.
2020-02-11 23:03:20 +01:00
Philipp Wolfer
12e8e20906 Fixed typo in changelog 2020-02-11 20:51:00 +01:00
Philipp Wolfer
58ffb8bb1c Generate SHA256 checksums for release packages 2020-02-11 16:48:33 +01:00
Philipp Wolfer
b836da0219 Release 2.3.0rc1 2020-02-11 16:30:44 +01:00
Philipp Wolfer
9c5f669acf Update translations 2020-02-11 15:44:53 +01:00
Philipp Wolfer
68a6ce79df Merge pull request #1465 from phw/PICARD-1688-batch-submit-acoustid
PICARD-1688: Submit AcoustID fingerprints in batches
2020-02-11 13:59:17 +01:00
Philipp Wolfer
dce902f192 PICARD-1688: Added tests for AcoustID submission 2020-02-11 13:35:04 +01:00
Philipp Wolfer
4abadede20 PICARD-1688: Code cleanup 2020-02-11 12:55:18 +01:00
Philipp Wolfer
c0185c7dec PICARD-1738: Load standalone-recording when searching for a recording URL 2020-02-11 12:00:31 +01:00
Philipp Wolfer
81c395fef2 Simplify the open_plugin_dir implementation 2020-02-11 10:54:40 +01:00
Philipp Wolfer
e7fe616512 PICARD-1688: Submit AcoustID fingerprints in batches
Avoids issues with exceeding the body size limit for submission requests. Also this makes the entire submission process more robust, as the submission of many fingerprints can now succeed partially instead of failing in its entirety.

The upper limit is around 250 fingerprints, which is equivalent to roughly 1 MiB of data. But use a batch count of actually 240 fingerprints per submission to have some leeway for varying data.
2020-02-10 17:09:31 +01:00
Philipp Wolfer
569c0bae46 Added categories to appdata 2020-02-10 16:36:54 +01:00
Laurent Monin
cb99c4a452 Merge pull request #1464 from zas/cache_size_const
Improve Network Cache size logging, use SI human-readable units
2020-02-10 15:13:44 +01:00
Laurent Monin
c93d9098f5 Improve debug infos about network cache
This code was arbitrarily use binary units instead of SI units.
Use `bytes2human` methods to produce human-readable output in the debug logs.
2020-02-10 13:39:51 +01:00
Laurent Monin
212db1c9f6 bytes2human: add l10n parameter to prevent localization
By default, localization happens, there was no way to disable it.
2020-02-10 13:39:51 +01:00
Philipp Wolfer
db8a2e1895 Bundle mutagen 1.44 for macOS / Windows builds 2020-02-10 12:07:35 +01:00
Laurent Monin
b727dfb4e3 Merge pull request #1462 from zas/tests_really_remove_dirs
Tests: ensure temporary directories and files are removed after tests
2020-02-09 23:10:23 +01:00
Laurent Monin
0631e5ff28 Move copy_file_tmp() and remove_file_tmp() to PicardTestCase
It helps to reduce code redundancy.
2020-02-08 18:04:39 +01:00
Laurent Monin
64291c309c Use NamedTemporaryFile instead of mkstemp 2020-02-08 18:04:39 +01:00
Laurent Monin
498c8eab1b Add mktmpdir method to PicardTestCase, and use it more widely 2020-02-08 18:04:39 +01:00
Laurent Monin
b7389a6445 Tests: ensure temporary directories and files are removed after tests
- QSettings object needs special care, as file was re-created on exit
- Append a cleanup function as soon as possible to ensure temporary dirs & files are removed in any case
- prefer addCleanup() over tearDown(), keeping creation and cleanup together
2020-02-08 18:04:39 +01:00
Philipp Wolfer
b7281c5147 Update picard.pot 2020-02-07 10:07:55 +01:00
Philipp Wolfer
901795907a PICARD-1724: Do not mark fingerprints in left pane for submission
Submitting fingerprints should only be done if files are properly matched to tracks on the right. They should not be marked as submittable if they are on the left, even if they have `musicbrainz_recordingid` set.
2020-02-07 09:58:57 +01:00
Philipp Wolfer
9fb4c954a9 PICARD-1737: Add keyboard shortcut for "Generate Fingerprints" 2020-02-07 09:58:00 +01:00
Philipp Wolfer
3cab7b04f9 PICARD-1736: Shorter label for "Generate Fingerprints" action in toolbar 2020-02-07 09:58:00 +01:00
Bob Swift
7762f9b929 Add $datetime() function and associated tests 2020-02-07 00:49:35 +01:00
Philipp Wolfer
f090c06572 CI: Also run package workflow when tests have changed
This provides proper builds after fixing tests.
2020-02-06 19:55:42 +01:00
Philipp Wolfer
7c6929286b Apply utime test workaround for all macOS versions.
This also seems not only on the macOS version but also on the Python build being used. On the build server with macOS 10.15 this works with the Python binaries provided on the server, but fails with official binaries from python.org.
2020-02-06 19:55:42 +01:00
Philipp Wolfer
f3aa0c1b08 PICARD-1733: Use official Python binaries on macOS
Fixes issues with builds not running on macOS 10.12 as the Python available on GHA is working only with macOS 10.13 and later.
2020-02-06 19:55:42 +01:00