Commit Graph

7535 Commits

Author SHA1 Message Date
Wieland Hoffmann
66a2369d83 Only update tagger.nats if it's not None
If it's None, there's nothing to update.
2014-04-11 15:32:05 +02:00
Wieland Hoffmann
33e67fa2d6 Merge branch 'plugin-addtracktomb' of https://github.com/Freso/picard 2014-04-11 14:12:53 +02:00
Laurent Monin
ec12c71dbd Merge pull request #282 from Sophist-UK/sophist_debug_log_album_already_loaded
Provide debug message if Album / NAT already loaded
2014-04-11 13:40:07 +02:00
Sophist
56ddac250d Provide debug message if already loaded
See http://forums.musicbrainz.org/viewtopic.php?id=4916 for example of
need.
2014-04-11 12:14:22 +01:00
Wieland Hoffmann
a1bf54bfdf Remove an unused import of defaultdict 2014-04-11 10:50:24 +02:00
Wieland Hoffmann
cce70806c7 Move the socket import to the not-win32 code path
Otherwise, we'd have to ship the socket module in the windows installer,
but it's not used on windows.
2014-04-11 10:49:33 +02:00
Michael Wiencek
e2c0e06ec8 s/coverart/cover art/ 2014-04-10 15:22:18 -05:00
Laurent Monin
cf52994989 PEP8 fixes. 2014-04-10 10:57:26 +02:00
Laurent Monin
68d424c250 Make Cover Art Type selector use available space 2014-04-10 10:34:25 +02:00
Laurent Monin
c2dc4df511 Update NEWS.txt 2014-04-10 10:21:36 +02:00
Laurent Monin
a2a84ac8e6 Convert release_type_scores option to ListOption
We had a space-separated list of name,value tuples ("Album 0.5 Other 0.4"),
and two helper functions to load and save data in the correct format
(`load_release_type_scores` and `save_release_type_scores`).

Since option is converted to recently-introduced ListOption, data is now saved
as a list of tuples, eventually converted to dict when needed.
It simplifies code, and also prevents an issue if it comes we have a release group type
with a space in its name.

An upgrade hook was added to handle this change on Picard upgrade.
2014-04-10 10:21:30 +02:00
Laurent Monin
91cd68022e Build release type score sliders UI dynamically. 2014-04-10 10:20:53 +02:00
Laurent Monin
e59fabda3f Build RELEASE_PRIMARY_GROUPS and RELEASE_SECONDARY_GROUPS from MB_ATTRIBUTES 2014-04-10 10:20:53 +02:00
Laurent Monin
175ed700b5 Ensure proper translation of cover art types 2014-04-10 10:20:53 +02:00
Laurent Monin
a53164a5ee Build RELEASE_FORMATS and CAA_TYPES from MB_ATTRIBUTES 2014-04-10 10:20:52 +02:00
Laurent Monin
490e24d243 Add ugettext_attr() function needed to translate attributes
Since contexts are used in attributes.pot, and python gettext do not yet
support contexts, a minor hack is used to make it work, this workaround
is used in django and babel, see ugettext_ctxt().
2014-04-10 10:20:52 +02:00
Laurent Monin
08fdb55414 Update picard/attributes.py and picard/countries.py
New setup.py update_constants command was used.
2014-04-10 10:20:52 +02:00
Laurent Monin
8ac7014dfe Add update_constants command to setup.py
It retrieves and parses attributes.pot and countries.pot files
from transifex to extract various constants needed in Picard.
It helps to keep those in sync with MusicBrainz website.

It then generates:
- picard/attributes.py containing cover art types, medium formats, and release group types
- picard/countries.py containing countries

`update_constants` command replaces `update_countries`
2014-04-10 10:20:52 +02:00
Laurent Monin
1b90304f16 Update pot file 2014-04-10 10:18:05 +02:00
Laurent Monin
1f4689d4fa Merge pull request #238 from Sophist-UK/sophist_add_open_collection_in_browser
Various UI improvements
2014-04-10 09:35:10 +02:00
Sophist
044d4482db Fix makeqrc same results Windows and Mac 2014-04-09 12:05:26 +01:00
Frederik "Freso" S. Olesen
8bca1ecfbb addrelease.py: Use approximated "~length" for Recordings.
Recordings don't support sub-second time precision, so the
track.metadata.length used for the two Add...AsRelease classes will
cause an error on /recording/create's "length" field.
track.metadata["~length"] contains the time converted to mm:ss format
and will not cause the error on /recording/create, so this commit
changes AddFileAsRecording to use that.
2014-04-08 21:55:12 +02:00
Sophist
244db6139d Add Play File plus icons ... 2014-04-08 18:33:31 +01:00
Sophist
c898d7d888 Make Lookup CD / Browser consistent, ...
... and fix if statement.

(zas comments).
2014-04-08 18:33:29 +01:00
Sophist
4347cc2cba Address various zas comments 2014-04-08 18:33:28 +01:00
Sophist
3b4b71d1ca Revert new status tips / tooltips ...
... and tweak browser integration tooltip.
2014-04-08 18:33:27 +01:00
Sophist
e6b2a20488 Add comment for zas 2014-04-08 18:33:26 +01:00
Sophist
d127edad8c And some more Bitmap comments...
which didn't show on the GitHub comments page.
2014-04-08 18:33:25 +01:00
Sophist
1a57e15f7a Fix tab order which I failed to adjust. 2014-04-08 18:33:23 +01:00
Sophist
d6e2cc499a Address even more Bitmap comments
Keep them coming Michael - every review comment = an improvement.
2014-04-08 18:33:22 +01:00
Sophist
9465737f51 Address more Bitmap comments 2014-04-08 18:33:21 +01:00
Sophist
faf05bd057 Address Bitmap comments. 2014-04-08 18:33:20 +01:00
Sophist
a18226ff28 Address zas comments 2014-04-08 18:33:18 +01:00
Sophist
47161d81de Swap Add Files/Directory...
... to reflect likely priority of usage i.e. most people will load
directories rather than files.
2014-04-08 18:33:17 +01:00
Sophist
5ec051923a Various UI improvements
1. Add consistent set of StatusTips / ToolTips
2. Move Refresh from View to Tools (its an action not changing view)
3. Rename and resequence Help menu.
4. Make sequence of files in a directory in Unmatched files be alphabetical (which should match album track sequence)
5. Make History text more consistent and user friendly and add Remove Album message.
6. Add Open Collection in Browser and reload collection if user details are changed in options
2014-04-08 18:33:15 +01:00
Wieland Hoffmann
5a2eee3484 Merge branch 'image-class-2'
Conflicts:
	picard/ui/infodialog.py
2014-04-08 13:13:22 +02:00
Wieland Hoffmann
b9a4f7898b increase the timer delay 2014-04-08 13:06:27 +02:00
Laurent Monin
64778f7dbd Merge pull request #256 from Sophist-UK/sophist_fix_missing_id3_tags_v2
Various tag tweaks.
2014-04-08 08:15:55 +02:00
Frederik "Freso" S. Olesen
b765452aac addrelease.py: Define form_values in __init__().
See https://github.com/musicbrainz/picard/pull/271/files#r11352974
2014-04-07 23:00:54 +02:00
Laurent Monin
e2695a5b5c Update translations 2014-04-07 16:54:00 +02:00
Laurent Monin
865722cbe1 Regenerate .py files from corresponding .ui files 2014-04-07 16:48:31 +02:00
Laurent Monin
7d1875ebe8 Merge pull request #266 from zas/build_ui_improvements
Add --files= option to setup.py build_ui
2014-04-07 07:58:12 +02:00
Laurent Monin
a141bc91ce Update NEWS.txt 2014-04-07 07:57:48 +02:00
Laurent Monin
a67ff7330f Merge remote-tracking branch 'upstream/master' into build_ui_improvements 2014-04-07 07:54:49 +02:00
Laurent Monin
8bc952db96 Merge branch 'sophist_fix_error_on_malformed_TRCK_tag' of git://github.com/Sophist-UK/picard into Sophist-UK-sophist_fix_error_on_malformed_TRCK_tag
Conflicts:
	NEWS.txt
2014-04-06 22:46:16 +02:00
Michael Wiencek
ae4524384a Move ID3Metadata functionality to new_metadata property
The problem with ID3Metadata is that it changes the behavior of
Metadata methods in undesirable ways (see PR #273).

This adds a new_metadata property to File classes which returns a copy
with the values modified as they'd be displayed/saved. This should more
composable and less error-prone than overriding Metadata methods across
the board.
2014-04-06 15:02:15 -05:00
Laurent Monin
1a312bf6ca Merge pull request #269 from Sophist-UK/sophist_fix_plugin_MENU_capability
Fix sub-menu capability for plugins...
2014-04-06 21:56:43 +02:00
Laurent Monin
4a390f7f44 Merge pull request #270 from Sophist-UK/sophist_show_id3_version
Show id3 version in info - resolves PICARD-218
2014-04-06 21:52:24 +02:00
Laurent Monin
c25c589191 Merge pull request #280 from zas/i18n_noop
Get rid of 'if logdebug: logdebug(...)' pattern using a noop function
2014-04-06 21:51:29 +02:00
Laurent Monin
3a2872d344 Restore time-stamp check, files depends too much on uic versions anyway
It works in most cases, and now one can force regeneration of one or more files
if needed.
2014-04-06 21:45:34 +02:00