Commit Graph

7535 Commits

Author SHA1 Message Date
Sophist
070f8939fd Make code clearer (as suggested by jesus2099) 2014-03-30 11:27:26 +01:00
Laurent Monin
7bc0d5ec63 Add missing whitelines. 2014-03-30 10:48:50 +02:00
Laurent Monin
348870819f Add --files= option to setup.py build_ui, to pass list of files to rebuild
Related to http://tickets.musicbrainz.org/browse/PICARD-566
2014-03-30 10:41:07 +02:00
Laurent Monin
bc222e7dce Move code generating py file name fro ui file name to its own function. 2014-03-30 10:39:15 +02:00
Laurent Monin
3d422f3da9 Reduce code redundancy using a generator 2014-03-30 10:04:46 +02:00
Sophist
3731ba833f Show multi-value variables as lists. 2014-03-29 15:27:38 +00:00
Laurent Monin
761db762ad PICARD-575: load plugins from contrib/ too when run from source directory
http://tickets.musicbrainz.org/browse/PICARD-575
2014-03-29 14:16:22 +01:00
Laurent Monin
61c7a340a9 self.log -> log
Forgotten during 201cdc269c
2014-03-29 13:44:08 +01:00
Laurent Monin
1aa619b923 Merge pull request #244 from zas/order_collections
PICARD-561: keep collections ordered like on the website
2014-03-29 13:29:59 +01:00
DanMan
af693808d7 Store ReplayGain info for MP3s in ID3v2 instead of APE tags (supported for years now) 2014-03-28 21:21:06 +01:00
Wieland Hoffmann
4dc1e36332 Merge branch 'sophist_hide_whatsthis_button' of github.com:Sophist-UK/picard 2014-03-28 16:17:11 +01:00
Wieland Hoffmann
c66ce78d64 Remove a commented print statement 2014-03-28 16:02:49 +01:00
Wieland Hoffmann
5552ddff38 Use None to denote a missing upper bound for script function arguments 2014-03-28 16:01:21 +01:00
Wieland Hoffmann
a299ae72dd Reorder imports 2014-03-28 15:52:52 +01:00
Wieland Hoffmann
93e80a8735 Use namedtuples for repeated access to the same elements
The position of the elements int he tuple have a meaning, this helps
understanding it when reading the code.
2014-03-28 15:50:59 +01:00
Sophist
35ba51351b Fix and extend artists tag ...
1. artists tag is incorrectly added to a release - now added only to a
track
2. add _albumartists and _albumartists_sort for use in scripts and
plugins.
2014-03-28 14:46:22 +00:00
Wieland Hoffmann
e90ceb9ab0 Merge branch 'Sophist-UK-sophist_better_script_functions_num_args_check' 2014-03-28 15:28:35 +01:00
Sophist
0688daa8bb Show variables for tracks without files 2014-03-28 14:07:13 +00:00
Laurent Monin
875c48245c Merge pull request #251 from Sophist-UK/sophist_add_trackid_variable_Picard-527
Add %_musicbrainz_tracknumber% to fix Picard-527 ...
2014-03-28 07:55:20 +01:00
Sophist
d65ecf4bdd Switch to ~musicbrainz_tracknumber 2014-03-27 20:23:23 +00:00
Laurent Monin
8ab5d6ae4b Merge pull request #258 from Sophist-UK/sophist_fix_minor_bugette_in_plugins
Possible minor bugette in plugin.py
2014-03-26 15:50:23 +01:00
Sophist
fabd16b62c Remove unneeded import of track. 2014-03-26 12:28:09 +00:00
Sophist
a850c0133f Handle pre/post #261 2014-03-26 12:21:10 +00:00
Sophist
2fbde0ee13 Move and rename default preserved tags
so that they can be used by other modules.
2014-03-26 11:43:24 +00:00
Sophist
90b4aec592 Add View Variables plugin 2014-03-26 11:03:22 +00:00
Sophist
7233604143 Improve script check for number of args.
Remove the need for specifying check_argcount=False if function uses
*args.

expected_args is now a 2-value tuple with lower and upper range of
argument counts.

Also, looks like a bug in calc if there were defaults.

Commented print string left in so correct range can be verified if
needed.
2014-03-25 21:17:52 +00:00
Sophist
5c25d56b7d No known instances of this problem but ...
... if plugin was located in picard.plugins_fake.smurf then module would
be set to "fake.smurf" rather than None.
2014-03-25 20:19:56 +00:00
Sophist
c45dd0d881 Remove unresolved merge conflict 2014-03-25 15:43:08 +00:00
Laurent Monin
70b2c7dea1 Merge pull request #257 from Sophist-UK/sophist_fix_test_bytes2human
Fix test bytes2human on Windows
2014-03-24 21:32:53 +01:00
Sophist
b80091b56e Use Universal Newline Support instead. 2014-03-24 20:11:14 +00:00
Laurent Monin
b07cd3739a Merge pull request #255 from Freso/cleanup-contrib-plugins
Clean up contrib plugins
2014-03-24 14:14:38 +01:00
Sophist
78d2ebf9a3 Strip CR as well as LF to avoid errors on Windows 2014-03-24 07:42:40 +00:00
Sophist
4a6d7d2047 Rovoke Work Title change. 2014-03-23 22:49:34 +00:00
Sophist
b3cffb1c71 Revert Work changes. 2014-03-23 22:49:03 +00:00
Sophist
a0fba0e7a4 Revert encoder settings for apev2 and asf. 2014-03-23 22:48:40 +00:00
Sophist
475dc7dffa Add NEWS.txt 2014-03-23 14:15:27 +00:00
Sophist
008bee3e2e Ensure multiple MBIDs are unique 2014-03-23 14:15:26 +00:00
Sophist
e3d18fb689 Improved tag descriptions...
... for Work and Website.
2014-03-23 14:15:25 +00:00
Sophist
83104c45f6 Remove obsolete tag names 2014-03-23 14:15:24 +00:00
Sophist
2e2b471291 Add support for id3v24 TDTG tagging timestamp 2014-03-23 14:15:23 +00:00
Sophist
2f3d7eb297 Add support for Encoder Settings (TSSE) 2014-03-23 12:55:12 +00:00
Sophist
b58294f933 Fix missing lyrics comparison
All other lyrics comparisons include this.
2014-03-23 12:55:11 +00:00
Sophist
86f2ff3f6b Save writer in Title Case
and handle anything saved with daily build.
2014-03-23 12:55:10 +00:00
Sophist
a7d77dc7c7 Move work to TOAL tag.
TOAL is defined in
>  TOAL - The 'Original album/movie/show title' frame is intended for the title of the original recording (or source of sound), if for example the music in the file should be a cover of a previously released song.

Whilst this is not explicitly the correct definition of Work Title, in practical terms it is as the Work typically is named the same as the original recording. In particular this will provide proper id3v23/4 support for classical music where the Track and Work titles are oftent very different.

Provide translation for anyone who has used daily builds with TXXX:Work.
2014-03-23 12:52:44 +00:00
Sophist
1568f2f349 Resequence tag order
to sequence in id3v24 documentation, in order to make audit easier.
2014-03-23 09:37:20 +00:00
Frederik "Freso" S. Olesen
511cc3c24d Remove open_in_gui.py plugin.
The functionality is included in Picard's core now, so there is no
need for a plugin to do it as well.
2014-03-23 07:55:30 +01:00
Frederik "Freso" S. Olesen
fcc42fbb12 Remove old/* plugins.
It's been almost 3 years since they were moved to the old/ folder, and
apparently they've not been needed enough by anyone to get an update
to current plugin API. If ever they're deemed useful again, they can
be pulled back via Git and updated.
2014-03-23 07:23:34 +01:00
Laurent Monin
148041e794 Sort collections list in a similar way than on the website
Not perfect, but simple enough.
2014-03-22 12:46:41 +01:00
Sophist
173332cf71 Move common code to a new PicardDialog class...
... and make existing dialogs sub-classes of this.
2014-03-21 22:08:53 +00:00
Sophist
0042acb7fc Hide whatsthis button from dialog boxes
Whatsthis button does not do anything.
2014-03-21 22:08:51 +00:00