Commit Graph

7535 Commits

Author SHA1 Message Date
Michael Wiencek
871e2467e8 Fix instance where QStringList is now a list (post-fa66e9f) 2014-04-06 13:40:20 -05:00
Frederik "Freso" S. Olesen
464aa50298 addrelease.py: Revert change to PLUGIN_NAME.
Per nikki's comment on pull request #271:
https://github.com/musicbrainz/picard/pull/271#discussion_r11242854
2014-04-05 13:17:01 +02:00
Sophist
0a87b62ee7 Update NEWS 2014-04-04 20:25:02 +01:00
Laurent Monin
acbebc3eb6 Get rid of 'if logdebug: logdebug(...)' pattern using a noop function
Suggested by @Mineo in https://github.com/musicbrainz/picard/pull/254/files#r11290500
2014-04-04 21:21:30 +02:00
Sophist
4ef7e133a6 Merge pull request #1 from zas/tpos_trck
@zas: Match TRCK and TPOS using regex and reduce code redundancy.

@sophist: I wondered whether this code was too difficult to read, but in the end decided it wasn't.
2014-04-04 19:11:09 +01:00
Sophist
97d6250452 Handle album finalisation correctly. 2014-04-04 19:05:05 +01:00
Sophist
08444f4d62 Minor tweak to display if variable is null string 2014-04-04 18:32:59 +01:00
Laurent Monin
8f91a9f7eb Use re named groups to match values and metadata keys. 2014-04-04 15:06:41 +02:00
Sophist
c22f93da50 Drop import time which is never used. 2014-04-04 13:28:20 +01:00
Sophist
35db0be391 Drop NEWS item re timestamp. 2014-04-04 13:26:10 +01:00
Wieland Hoffmann
9f85083025 Add comments to the signal handling code 2014-04-04 12:39:39 +02:00
Laurent Monin
09f726fcdc Match TRCK and TPOS using regex and reduce code redundancy. 2014-04-04 12:07:50 +02:00
Sophist
02168dc50d Provide same checks for TPOS 2014-04-03 18:03:26 +01:00
Laurent Monin
a90de48d7a Merge pull request #278 from Sophist-UK/sophist_fix_test_mbxml_after_#268
Fix broken test_mbxml
2014-04-03 16:22:36 +02:00
Laurent Monin
6a62045370 Merge pull request #274 from Sophist-UK/sophist_fix_typo_in_#251
Fix typo in #251
2014-04-03 16:21:07 +02:00
Sophist
b3d92437be Fix broken test_mbxml
broken by commit 6922848545
2014-04-03 14:22:41 +01:00
Sophist
388a48219e Provide error log on invalid format. 2014-04-03 13:57:54 +01:00
Sophist
0f2e62796c Fix error on malformed TRCK tag. 2014-04-03 13:54:46 +01:00
Sophist
14c8a68ad8 Fix typo in commit d65ecf4bdd 2014-04-03 13:44:58 +01:00
Laurent Monin
6922848545 Merge pull request #268 from Sophist-UK/sophist_fix_and_extend_artists_tag
Fix and extend artists tag ...
2014-04-03 12:32:30 +02:00
Sophist
60bfe8d845 Remove unneeded imports 2014-04-03 11:05:32 +01:00
Sophist
8dec7fb20f Tweak NEWS 2014-04-03 10:57:09 +01:00
Sophist
c3ee57ee64 Add NEWS 2014-04-03 10:29:20 +01:00
Sophist
930b7481a3 Add NEWS.txt 2014-04-03 10:26:09 +01:00
Sophist
6d76c0b7cf Add Album Artist Website plugin - see PICARD-26
Adds a plugin to get the artist homepage MB relationship and insert into
website (ID3 WOAR tag).

Note: I used this plugin as a trial for using a Picard xml module to
handle MB WS2 xml response. See PICARD-581.
2014-04-03 10:24:33 +01:00
Frederik "Freso" S. Olesen
77af0591b0 addrelease.py: Improve PEP8 compliance (E701).
Fixing instance of error E701: multiple statements on one line (colon).
2014-04-02 17:57:03 +02:00
Frederik "Freso" S. Olesen
bf0fab7f3d addrelease.py: Update plugin metadata.
- Add Freso to PLUGIN_AUTHOR
- Update PLUGIN_NAME and _DESCRIPTION to describe added file
  functionality.
- Increment PLUGIN_VERSION to 0.5.
2014-04-02 17:50:32 +02:00
Frederik "Freso" S. Olesen
ddcf02b339 addrelease.py: Add AddFileAsRelease class.
Allows for easily adding single files (which can't be clustered) as releases.
2014-04-02 17:44:48 +02:00
Frederik "Freso" S. Olesen
eaa5474445 addrelease.py: Add AddFileAsRecording class.
Allows for easily adding individual files as standalone recordings.
2014-04-02 17:22:41 +02:00
Frederik "Freso" S. Olesen
713061b82f addrelease.py: Abstract out submission URL. 2014-04-02 17:20:24 +02:00
Frederik "Freso" S. Olesen
060f2a3812 addrelease.py: Abstract .callback() to parent class.
Child classes now just need to define object type, NAME, and the
set_form_values() method - and reigster_*_action.
2014-04-02 16:36:40 +02:00
Frederik "Freso" S. Olesen
fe06a50369 addrelease.py: Refactor AddClusterAsRelease.
Abstract out some of the functionality all clumped together in
AddClusterAsRelease.callback() to methods of new parent class
AddObjectAsEntity.
2014-04-02 16:13:13 +02:00
Sophist
0f274c8ab0 Show id3 version in info - resolves PICARD-218 2014-04-01 20:17:05 +01:00
Sophist
5a84fcd4d1 Drop id3v24 tagging timestamp. 2014-04-01 18:08:37 +01:00
Sophist
8ebb2e1b0d Add NEWS.txt 2014-04-01 08:01:47 +01:00
Laurent Monin
49ccc572dc Merge pull request #246 from m42i/highlighting_comments
Highlighting $noop() comments differently
2014-03-31 23:54:26 +02:00
Sophist
704c68f76f Minor style improvement 2014-03-31 22:25:11 +01:00
Sophist
0fcf46c9bf Fix display of multi-value for id3v23 2014-03-31 21:02:33 +01:00
Laurent Monin
e97f404fff Update test_formats: defaultdict -> LockableDefaultDict 2014-03-31 21:33:32 +02:00
Laurent Monin
906e38f992 Lock images dict when writing, it is needed to avoid double saved images 2014-03-31 21:32:21 +02:00
Laurent Monin
d4753031d0 Add a bit of debug log when images are saved to temp files 2014-03-31 21:29:15 +02:00
Laurent Monin
13d95e309a Add lockable default dict class 2014-03-31 21:28:12 +02:00
Laurent Monin
5a266b1a25 Fix the need to re-focus window after ctrl+c interrupt for the app to exit 2014-03-31 21:25:11 +02:00
Laurent Monin
0863b1e956 Merge pull request #261 from Sophist-UK/sophist_move_MEDIA_TAGS
Move and rename default preserved tags
2014-03-31 20:24:53 +02:00
Sophist
56ac2849b9 Fix sub-menu capability for plugins...
1. xrange(x, y) goes from x to y-1. If len(MENU) is 1 this is never
called. So add 1 to get correct range.

2. Exception handling is typically slower and code is less clear than if
we just test for the key existing.
2014-03-31 17:47:44 +01:00
Laurent Monin
d3d418de54 Drop time-stamp comparison, remove variable comments from generated files.
See discussion at http://tickets.musicbrainz.org/browse/PICARD-566
2014-03-31 15:13:19 +02:00
Laurent Monin
fc1d24e276 Merge pull request #264 from DanMan/master
Store ReplayGain info for MP3s in ID3v2 instead of APE tags
2014-03-31 14:47:34 +02:00
Sophist
207e7de8b1 Switch back to PRESERVED_TAGS 2014-03-31 07:24:50 +01:00
Laurent Monin
dd6a124292 Allow compilation of ui files in unusual directories.
.py file will be produced in the same directory of the .ui file
2014-03-30 15:46:54 +02:00
Laurent Monin
102f03df40 Merge pull request #267 from Sophist-UK/sophist_correct_absolutetracknumber_variable
Make code clearer (as suggested by jesus2099)
2014-03-30 13:17:34 +02:00