Commit Graph

9664 Commits

Author SHA1 Message Date
Philipp Wolfer
eefe7e35f3 Revert "PICARD-2609: Run metadata comparison on file.update in a thread"
This reverts commit 8a3a3424b9.
2023-07-06 15:30:48 +02:00
Philipp Wolfer
b41f93eed0 Updated translations from transifex 2023-07-06 15:30:18 +02:00
Philipp Wolfer
d3b60e0ccb Merge pull request #2252 from phw/pipe-reintroduce-thread-pool
Pipe refactor thread pool
2023-07-06 09:18:16 +02:00
Philipp Wolfer
5b61c2d907 Handle ThreadPool.shutdown cancel_futures argument being only available in Python 3.9 and later 2023-07-06 08:15:25 +02:00
Philipp Wolfer
8a2d0f0d53 Do not use a thread pool for read_from_pipe()
This method is already meant to run in a loop in a separate thread,
no need to spawn additional threads. Also this does not need to timeout
all the time. It is ok the thread waits until data becomes available
instead of looping all the time using CPU resources. Stopping the
pipe reader thread is done on application exit by a message.
2023-07-06 08:15:25 +02:00
Philipp Wolfer
a7c4867137 Increase timeout for reading from pipe
This keeps the thread longer waiting and avoids processing overhead.

Still timeout should be short enough to not block shutdown of the thread for too long.
2023-07-06 08:15:25 +02:00
Philipp Wolfer
36f1f255f9 Re-introduce thread pool for pipe
Creating a thread pool on each read / write for only a single thread is inefficient.
2023-07-06 08:15:24 +02:00
Philipp Wolfer
bf9ec7aa49 PICARD-2679: Fix open folder for Snap install
When running as a Snap use xdg-open instead of QDesktopServices.
Introduce picard.util.open_local_path helper to wrap this functionality.
2023-07-03 19:48:53 +02:00
Philipp Wolfer
8fd35b975d Revert "macOS 10.12: Build with PyQt 5.13.2"
This reverts commit 36b5dab2c4.
2023-07-03 12:34:34 +02:00
Philipp Wolfer
a80a186a24 PICARD-2668: Ensure application quit() runs all exit() cleanup tasks
This avoids issues like pipe handler hanging with waiting threads after
main application crashed.
2023-07-03 10:31:10 +02:00
Laurent Monin
08a40881a5 Handle exceptions better in piper sender/reader threads 2023-07-03 10:31:10 +02:00
Philipp Wolfer
a0efffb6ce PICARD-2665: Revert "PICARD-2634: Use standardized artist names by default"
This reverts commit 5a9d6b9581.
2023-07-03 08:21:10 +02:00
Philipp Wolfer
1482f9cc56 Fixed extracting translation for first run dialog 2023-07-02 12:07:29 +02:00
Philipp Wolfer
e6d2d7fb33 Update picard.pot 2023-07-02 11:52:43 +02:00
Bob Swift
104f718a31 Merge pull request #2246 from rdswift/new_user_dialogs
PICARD-2671: Add file save confirmation and first run dialogs
2023-06-30 15:38:47 -06:00
Laurent Monin
15db874b06 show_new_user -> show_new_user_dialog (#16) 2023-06-29 16:11:59 -06:00
Bob Swift
4d364fcffb Add option setting to re-enable the new user dialog 2023-06-29 15:48:30 -06:00
Bob Swift
8ee05ef606 Change double spaces between sentences to single. 2023-06-29 10:28:31 -06:00
Bob Swift
f7a1ad5c53 Change the way the documentation link is displayed
Co-authored-by: Laurent Monin <github@norz.org>
2023-06-28 18:53:26 -06:00
Bob Swift
47cf43a217 Change new user messagebox icon
Co-authored-by: Laurent Monin <github@norz.org>
2023-06-28 18:50:07 -06:00
Bob Swift
9b1d1bcd62 Shorten the new user message. Add new constant for docs server. 2023-06-28 15:53:55 -06:00
Bob Swift
2d03913d33 Add number of files processed to warning. Clean up variable names. 2023-06-28 14:54:26 -06:00
Bob Swift
a19cc1f896 Another i18n fix. 2023-06-27 10:18:14 -06:00
Bob Swift
e7a22ebdb7 Update message text and message classes:
- Rename firstrundialog module and class to newuserdialog
- Rename 'first_run' persistent variable to 'show_new_user'
- Remove unused super classes.
- Add license url to PICARD_URLS constant dictionary.
- Add documentation and licence links to first run dialog.
- Strengthen warning about using backups of music files and running
small batches.
- Add note about using at your own risk.
- Refactor text for file save warning for proper translation.
2023-06-27 09:52:51 -06:00
Bob Swift
300f95763c Add file save confirmation and first run dialogs. 2023-06-26 17:24:21 -06:00
Philipp Wolfer
47fea52c3a Update picard.pot 2023-06-26 17:27:50 +02:00
Laurent Monin
fa5e24f1ec PICARD-2662: display a more explicit message on Mutagen errors (#2245)
* PICARD-2662: display a more explicit message on Mutagen errors

* MUTAGEN -> PARSER
2023-06-26 14:56:55 +02:00
Philipp Wolfer
203aa6bd4a PICARD-2659: Fix endless login loop
Attempting to do authenticated calls against HTTP on musicbrainz.org
leads to authentication errors. Enforce all calls to use HTTPS.

This is a regression introduced by recent webservice refactoring.
2023-06-16 18:46:31 +02:00
Philipp Wolfer
e41b0d5338 Revert validating with appstream-util again
The appstreamcli currently available on Gitlab CI ubuntu-latest does not
support recommends > internet.
2023-06-16 10:35:36 +02:00
Philipp Wolfer
d22bf0d445 Fix appstream XML and use appstreamcli for validation 2023-06-16 10:35:36 +02:00
Laurent Monin
a5fcd0848e Add notes about packages to install for discid & embedded player 2023-06-16 09:14:32 +02:00
Philipp Wolfer
135e73e704 Release 2.9.0b2 2023-06-15 11:56:53 +02:00
Laurent Monin
180a5fea8e Update INSTALL.md source run/dev instructions 2023-06-15 11:51:46 +02:00
Philipp Wolfer
1b7da491f0 Updated translations from transifex 2023-06-15 08:10:54 +02:00
Philipp Wolfer
7ee078852a Use notarytool for macOS notarization
Notarization with the altool has been deprecated, see
https://developer.apple.com/documentation/technotes/tn3147-migrating-to-the-latest-notarization-tool
2023-06-14 23:33:15 +02:00
Laurent Monin
48fc4dd9fc Merge pull request #2237 from zas/search_dialog_limit_countries
PICARD-2481: shorten country long lists in search results
2023-06-13 16:28:01 +02:00
Laurent Monin
ec9090f115 PICARD-2481: shorten country long lists in search results
Use limited_join() as we do elsewhere to limit the size of the list to something usable.

Add new `countries_shortlist()` to wrap call to `limited_join()`
2023-06-13 15:55:51 +02:00
Laurent Monin
8f09816c66 Avoid setting format, it's a builtin, rename to fmt 2023-06-13 11:51:51 +02:00
Laurent Monin
351a099845 _request_recording_relationships(): drop unused config parameter
config isn't used in the method, so no need to set it or to pass it
2023-06-13 11:51:51 +02:00
Laurent Monin
db41001a32 Merge pull request #2235 from zas/i18n_tidyup
Rework _try_locales(), introduce _try_encodings(), and add tests for …
2023-06-13 08:25:10 +02:00
Laurent Monin
497aeae35b Rework _try_locales(), introduce _try_encodings(), and add tests for them 2023-06-12 23:29:56 +02:00
Philipp Wolfer
54337a2dff Changed UI translations from Transifex since last release 2023-06-12 08:46:15 +02:00
Philipp Wolfer
580617b5e7 Build with PyInstaller 5.12 2023-06-11 17:44:27 +02:00
Philipp Wolfer
27edb07068 Merge pull request #2231 from phw/i18n-tests
Refactor loading of locales in i18n module, extended logging and added tests
2023-06-11 17:40:51 +02:00
Laurent Monin
86bbf2a45f Merge pull request #2225 from zas/ws_url
Introduce WebService (get|post|put|delete|download)_url() methods
2023-06-11 17:09:30 +02:00
Laurent Monin
b9e45fdaa2 Log related env variables when language is set to system 2023-06-11 16:56:37 +02:00
Laurent Monin
53c859944e Rework the way locales are guessed and set, simplify code
- create lists of candidates, then try
- improve logging
- instead of setting env vars for gettext language selection, use `gettext.translation()` `languages` parameter
- try 'UTF-8' only once if it is the preferred encoding
2023-06-11 16:56:37 +02:00
Laurent Monin
c495ab4a42 macos: return set locale if possible, and just return set_locale_from_env() if not 2023-06-11 16:56:37 +02:00
Laurent Monin
54801d97df Now that we default to 'C' locale for tests, remove redundant setups 2023-06-11 16:56:37 +02:00
Laurent Monin
386bbd683d test_existing_locales(): assert the _() changed after setup 2023-06-11 16:56:37 +02:00