The following errors are found during appdata checking:
* org.flameshot.flameshot: missing-desktop-file
* flameshot.desktop: no-metainfo
The root cause is the lack of a <launchable type="desktop-id"> tag
in the metainfo file that references the name of .desktop file.
This commit fixes that.
(Another solution would be renaming flameshot.desktop to be
org.flameshot.flameshot.desktop.)
Originally the App uses org.dharkael.Flameshot in D-Bus.
Since we have moved the project under organization, the
name we are using now should be org.flameshot.Flameshot.
This need to be kept unified across the whole project.
This fixes D-Bus invocation problem and should fixes: #850 .
SVG images have been optimized with svgo, this will slightly reduce package size though the main reason for this was to remove unneeded markup.
Image paths have been changed and merged, now the directory tree looks like this:
img
├── app
├── material
│ ├── black
│ └── white
└── preview
The reason to merge the paths is to avoid duplicate files for buttons and configuration.
SVG icons are used by default now, PNG images have not been deleted from the images directory, but they were deleted from the graphics.qrc resource file.
All image paths were updated accordingly, except in the tray icon, I could not make it work using the SVG image.
Compiling the project without git installed uses a hardcoded
version with a *-dev ending in the dev versions instead of
the specific commit information after the version.
* removed shebang;
* removed encoding tag as it no longer required;
* changed chmod from 755 to 644 as required by standard.
Signed-off-by: Vitaly Zaitsev <vitaly@easycoding.org>
-use of the override keyword
-delete unused code
-const correctness
-more uniform code style
-for each with const references when possible
-getters no longer use the word 'get'
-others
The controller class has some important methods which may be
required in multiple parts of the code. Now that class is a
singleton (that may change in the future).
The core parts have been moved to src/core.
Now the tray Icon can be disabled by the controller.
I need to reimplement a new notification system due to its
dependency with the tray icon, they are disabled in this actual
commit.