This includes both the image type (for vorbis, id3 and asf files) as
well as the comments (as description for vorbis, id3 and asf files).
Additionally, converts the `images` attribute of
picard.metadata.Metadata to a list of dicts instead of tuples for easier
access.
tagger.lookup_cd is connected to by a QMenu.triggered and a
QAction.triggered. The latter sends a "checked" argument even if the
QAction is not checkable, so action is never None. The old-style signal
syntax allowed you to ignore arguments for certain connections.
This didn't do anything other than compare the albumartist, and then
call Metadata.compare_to_release and combine the results. It's confusing
to have these metadata-XML comparison functions strewn all over, so I moved
the albumartist comparison to Metadata.compare_to_release, and also moved
File._compare_to_track to Metadata.compare_to_track, just to make things
consistent.
This commit shouldn't change the matching/scoring behavior at all, it only
sheds some code.
This extends the coverart plugin to provide an options page so users can
configure which cover art provider they want to use and, in case of the
CAA, which image sizes and image types to download.
There were a few annoyances I had with the current code...
1. The indirection surrounding the __get and __set methods is a chore to
read when trying to debug things.
2. It implemented methods like keys, pop, __contains__, __delitem__, and
__repr__ that duplicated the default dict functionality.
3. Other modules were accessing _items to work around certain behavior,
which wasn't ideal.
The current metadata object will always be empty, and the new one will be
otherwise garbage collected. There are also no places in the code where a
reference to the old metadata object would be stored, other than
file.metadata.